Sign upLogin

asteris-llc/converge

View on GitHub
Star
resource/lvm/lowlevel/exec_test.go

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    t.Run("zero code", func(t *testing.T) {
        defer logging.HideLogs(t)()
        e := lowlevel.MakeOsExec()
        out, rc, err := e.ReadWithExitCode("/bin/sh", []string{"-c", "echo foo"})
        assert.NoError(t, err)
Severity: Minor
Found in resource/lvm/lowlevel/exec_test.go and 1 other location - About 45 mins to fix
resource/lvm/lowlevel/exec_test.go on lines 114..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 116.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    t.Run("non-zero code", func(t *testing.T) {
        defer logging.HideLogs(t)()
        e := lowlevel.MakeOsExec()
        out, rc, err := e.ReadWithExitCode("/bin/sh", []string{"-c", "echo foo && exit 42"})
        assert.NoError(t, err)
Severity: Minor
Found in resource/lvm/lowlevel/exec_test.go and 1 other location - About 45 mins to fix
resource/lvm/lowlevel/exec_test.go on lines 105..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 116.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    t.Run("normal", func(t *testing.T) {
        defer logging.HideLogs(t)()
        e := lowlevel.MakeOsExec()
        out, err := e.Read("/bin/sh", []string{"-c", "echo foo"})
        assert.NoError(t, err)
Severity: Major
Found in resource/lvm/lowlevel/exec_test.go and 3 other locations - About 30 mins to fix
resource/lvm/lowlevel/exec_test.go on lines 68..74
resource/lvm/lowlevel/exec_test.go on lines 79..85
resource/lvm/lowlevel/exec_test.go on lines 87..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    t.Run("non-zero code", func(t *testing.T) {
        defer logging.HideLogs(t)()
        e := lowlevel.MakeOsExec()
        rc, err := e.RunWithExitCode("/bin/sh", []string{"-c", "exit 42"})
        assert.NoError(t, err)
Severity: Major
Found in resource/lvm/lowlevel/exec_test.go and 3 other locations - About 30 mins to fix
resource/lvm/lowlevel/exec_test.go on lines 48..54
resource/lvm/lowlevel/exec_test.go on lines 68..74
resource/lvm/lowlevel/exec_test.go on lines 79..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    t.Run("multiline", func(t *testing.T) {
        defer logging.HideLogs(t)()
        e := lowlevel.MakeOsExec()
        out, err := e.Read("/bin/sh", []string{"-c", "echo foo && echo bar"})
        assert.NoError(t, err)
Severity: Major
Found in resource/lvm/lowlevel/exec_test.go and 3 other locations - About 30 mins to fix
resource/lvm/lowlevel/exec_test.go on lines 48..54
resource/lvm/lowlevel/exec_test.go on lines 79..85
resource/lvm/lowlevel/exec_test.go on lines 87..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    t.Run("zero code", func(t *testing.T) {
        defer logging.HideLogs(t)()
        e := lowlevel.MakeOsExec()
        rc, err := e.RunWithExitCode("/bin/sh", []string{"-c", "true"})
        assert.NoError(t, err)
Severity: Major
Found in resource/lvm/lowlevel/exec_test.go and 3 other locations - About 30 mins to fix
resource/lvm/lowlevel/exec_test.go on lines 48..54
resource/lvm/lowlevel/exec_test.go on lines 68..74
resource/lvm/lowlevel/exec_test.go on lines 87..93

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 102.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status