asteris-llc/converge

View on GitHub
resource/lvm/vg/vg_test.go

Summary

Maintainability
C
1 day
Test Coverage

Function TestVGCheck has 65 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestVGCheck(t *testing.T) {
    t.Run("check prerequisites failure", func(t *testing.T) {
        lvm, m := testhelpers.MakeFakeLvm()
        m.On("Check").Return(fmt.Errorf("failed"))
        _ = simpleCheckFailure(t, lvm, "vg0", []string{"/dev/sda1"}, false, false)
Severity: Minor
Found in resource/lvm/vg/vg_test.go - About 1 hr to fix

    Function TestVGApply has 61 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestVGApply(t *testing.T) {
        t.Run("single device", func(t *testing.T) {
            lvm, m := testhelpers.MakeFakeLvmEmpty()
            m.On("CreateVolumeGroup", mock.Anything, mock.Anything).Return(nil)
    
    
    Severity: Minor
    Found in resource/lvm/vg/vg_test.go - About 1 hr to fix

      Function simpleCheckSuccess has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func simpleCheckSuccess(t *testing.T, lvm lowlevel.LVM, group string, devs []string, remove bool, forceRemove bool) (resource.TaskStatus, resource.Task) {
      Severity: Minor
      Found in resource/lvm/vg/vg_test.go - About 45 mins to fix

        Function simpleApplySuccess has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func simpleApplySuccess(t *testing.T, lvm lowlevel.LVM, group string, devs []string, remove bool, forceRemove bool) resource.TaskStatus {
        Severity: Minor
        Found in resource/lvm/vg/vg_test.go - About 45 mins to fix

          Function simpleApplyFailure has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func simpleApplyFailure(t *testing.T, lvm lowlevel.LVM, group string, devs []string, remove bool, forceRemove bool) resource.TaskStatus {
          Severity: Minor
          Found in resource/lvm/vg/vg_test.go - About 45 mins to fix

            Function simpleCheckFailure has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func simpleCheckFailure(t *testing.T, lvm lowlevel.LVM, group string, devs []string, remove bool, forceRemove bool) resource.TaskStatus {
            Severity: Minor
            Found in resource/lvm/vg/vg_test.go - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func simpleApplySuccess(t *testing.T, lvm lowlevel.LVM, group string, devs []string, remove bool, forceRemove bool) resource.TaskStatus {
                  checkStatus, vg := simpleCheckSuccess(t, lvm, group, devs, remove, forceRemove)
                  require.True(t, checkStatus.HasChanges())
              
                  status, err := vg.Apply(context.Background())
              Severity: Major
              Found in resource/lvm/vg/vg_test.go and 1 other location - About 1 hr to fix
              resource/lvm/vg/vg_test.go on lines 282..289

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 131.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              func simpleApplyFailure(t *testing.T, lvm lowlevel.LVM, group string, devs []string, remove bool, forceRemove bool) resource.TaskStatus {
                  checkStatus, vg := simpleCheckSuccess(t, lvm, group, devs, remove, forceRemove)
                  require.True(t, checkStatus.HasChanges())
              
                  status, err := vg.Apply(context.Background())
              Severity: Major
              Found in resource/lvm/vg/vg_test.go and 1 other location - About 1 hr to fix
              resource/lvm/vg/vg_test.go on lines 273..280

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 131.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  t.Run("device remove", func(t *testing.T) {
                      lvm, _ := testhelpers.MakeFakeLvmNonEmpty()
                      status, _ := simpleCheckSuccess(t, lvm, "vg1", []string{"/dev/sdc1"}, true, false)
                      assert.True(t, status.HasChanges())
                      comparison.AssertDiff(t, status.Diffs(), "/dev/sdd1", "<group vg1>", "<removed>")
              Severity: Minor
              Found in resource/lvm/vg/vg_test.go and 1 other location - About 50 mins to fix
              resource/lvm/vg/vg_test.go on lines 89..97

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 122.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  t.Run("device force remove", func(t *testing.T) {
                      lvm, _ := testhelpers.MakeFakeLvmNonEmpty()
                      status, _ := simpleCheckSuccess(t, lvm, "vg1", []string{"/dev/sdc1"}, true, true)
                      assert.True(t, status.HasChanges())
                      comparison.AssertDiff(t, status.Diffs(), "/dev/sdd1", "<group vg1>", "<destructed>")
              Severity: Minor
              Found in resource/lvm/vg/vg_test.go and 1 other location - About 50 mins to fix
              resource/lvm/vg/vg_test.go on lines 79..87

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 122.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status