Sign upLogin

asteris-llc/converge

View on GitHub
Star
resource/preparer.go

Summary

Maintainability
D
2 days
Test Coverage

Preparer has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

type Preparer struct {
    Source      map[string]interface{}
    Destination Resource
}
Severity: Minor
Found in resource/preparer.go - About 2 hrs to fix

    Method Preparer.validateMutuallyExclusive has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
    Open

    func (p *Preparer) validateMutuallyExclusive(field reflect.StructField) error {
    if mutuallyexclusives, ok := field.Tag.Lookup("mutually_exclusive"); ok {
        name := p.getFieldName(field)

        exclusives := strings.Split(mutuallyexclusives, ",")
    Severity: Minor
    Found in resource/preparer.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method Preparer.convertNumber has 65 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (p *Preparer) convertNumber(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
    if val == nil {
        return reflect.Zero(typ), nil
    }
    Severity: Minor
    Found in resource/preparer.go - About 1 hr to fix

      Method Preparer.getValueForField has 8 return statements (exceeds 4 allowed).
      Open

      func (p *Preparer) getValueForField(r Renderer, field reflect.StructField) (reflect.Value, error) {
    // get the field name for use in future lookups
    name := p.getFieldName(field)
    raw, isSet := p.Source[name]
      Severity: Major
      Found in resource/preparer.go - About 50 mins to fix

        Method Preparer.convertNumber has 6 return statements (exceeds 4 allowed).
        Open

        func (p *Preparer) convertNumber(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
    if val == nil {
        return reflect.Zero(typ), nil
    }
        Severity: Major
        Found in resource/preparer.go - About 40 mins to fix

          Method Preparer.convertSlice has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func (p *Preparer) convertSlice(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
          Severity: Minor
          Found in resource/preparer.go - About 35 mins to fix

            Method Preparer.convertTime has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func (p *Preparer) convertTime(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
            Severity: Minor
            Found in resource/preparer.go - About 35 mins to fix

              Method Preparer.convertMap has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func (p *Preparer) convertMap(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
              Severity: Minor
              Found in resource/preparer.go - About 35 mins to fix

                Method Preparer.convertValue has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                func (p *Preparer) convertValue(typ reflect.Type, r Renderer, name string, val interface{}, base int) (out reflect.Value, err error) {
                Severity: Minor
                Found in resource/preparer.go - About 35 mins to fix

                  Method Preparer.convertDuration has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  func (p *Preparer) convertDuration(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
                  Severity: Minor
                  Found in resource/preparer.go - About 35 mins to fix

                    Method Preparer.convertNumber has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    func (p *Preparer) convertNumber(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
                    Severity: Minor
                    Found in resource/preparer.go - About 35 mins to fix

                      Method Preparer.convertPointer has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      func (p *Preparer) convertPointer(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
                      Severity: Minor
                      Found in resource/preparer.go - About 35 mins to fix

                        Method Preparer.convertInterface has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        func (p *Preparer) convertInterface(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
                        Severity: Minor
                        Found in resource/preparer.go - About 35 mins to fix

                          Method Preparer.Prepare has 5 return statements (exceeds 4 allowed).
                          Open

                          func (p *Preparer) Prepare(ctx context.Context, r Renderer) (Task, error) {
    value := reflect.ValueOf(p.Destination)
    typ := value.Type()
    wasPtr := false // so we can re-wrap later if we need to
                          Severity: Major
                          Found in resource/preparer.go - About 35 mins to fix

                            Method Preparer.convertMap has 5 return statements (exceeds 4 allowed).
                            Open

                            func (p *Preparer) convertMap(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
    if val == nil {
        return reflect.Zero(typ), nil
    }
                            Severity: Major
                            Found in resource/preparer.go - About 35 mins to fix

                              Method Preparer.convertDuration has 5 return statements (exceeds 4 allowed).
                              Open

                              func (p *Preparer) convertDuration(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
    if val == nil {
        return reflect.Zero(typ), nil
    }
                              Severity: Major
                              Found in resource/preparer.go - About 35 mins to fix

                                Method Preparer.convertTime has 5 return statements (exceeds 4 allowed).
                                Open

                                func (p *Preparer) convertTime(typ reflect.Type, r Renderer, name string, val interface{}, base int) (reflect.Value, error) {
    if val == nil {
        return reflect.Zero(typ), nil
    }
                                Severity: Major
                                Found in resource/preparer.go - About 35 mins to fix

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                      case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
        raw, err := strconv.ParseInt(num, base, typ.Bits())

        if err != nil {
            return reflect.Zero(typ), errors.Wrapf(err, "could not convert %s to %s", num, typ.Kind())
                                  Severity: Major
                                  Found in resource/preparer.go and 1 other location - About 2 hrs to fix
                                  resource/preparer.go on lines 529..551

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 217.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  Similar blocks of code found in 2 locations. Consider refactoring.
                                  Open

                                      case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64:
        raw, err := strconv.ParseUint(num, base, typ.Bits())

        if err != nil {
            return reflect.Zero(typ), errors.Wrapf(err, "could not convert %s to %s", num, typ.Kind())
                                  Severity: Major
                                  Found in resource/preparer.go and 1 other location - About 2 hrs to fix
                                  resource/preparer.go on lines 505..527

                                  Duplicated Code

                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                  Tuning

                                  This issue has a mass of 217.

                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                  Refactorings

                                  Further Reading

                                  error strings should not be capitalized or end with punctuation or a newline
                                  Open

                                                      errs := fmt.Errorf("could not convert %s to time.Time any of:\n1. %v\n2. %v\n3. %v\n", name, ztErr, ltErr, stErr)
                                  Severity: Minor
                                  Found in resource/preparer.go by golint

                                  Your code does not pass gofmt in 1 place. Go fmt your code!
                                  Open

                                  // Copyright © 2016 Asteris, LLC
                                  Severity: Minor
                                  Found in resource/preparer.go by gofmt

                                  There are no issues that match your filters.

                                  Category
                                  Status