Sign upLogin

atk4/api

View on GitHub
Star

Showing 5 of 6 total issues

Method rest has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function rest($pattern, $model = null, $methods = ['read', 'modify', 'delete'])
    {
        $methods = array_map('strtolower', $methods);

        // GET all records
Severity: Major
Found in src/Api.php - About 2 hrs to fix

    Function rest has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public function rest($pattern, $model = null, $methods = ['read', 'modify', 'delete'])
    {
        $methods = array_map('strtolower', $methods);

        // GET all records
    Severity: Minor
    Found in src/Api.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method match has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function match($pattern)
    {
        $path = explode('/', rtrim($this->path, '/'));
        $pattern = explode('/', rtrim($pattern, '/'));
    Severity: Minor
    Found in src/Api.php - About 1 hr to fix

      Method init has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function init(): void
    {
        parent::init();

        $this->addField('name', ['actual' => 'nicename', 'required' => true, 'type' => 'string']);
      Severity: Minor
      Found in examples/Country.php - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                        return !$model->delete($id)->loaded();
        Severity: Major
        Found in src/Api.php - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language