Sign upLogin

atk4/dsql

View on GitHub
Star
src/Connection.php

Summary

Maintainability
F
4 days
Test Coverage

Method connectDbalConnection has 219 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected static function connectDbalConnection(array $dsn)
    {
        if (isset($dsn['pdo'])) {
            $pdo = $dsn['pdo'];
        } else {
Severity: Major
Found in src/Connection.php - About 1 day to fix

    File Connection.php has 402 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

declare(strict_types=1);

namespace Atk4\Dsql;
    Severity: Minor
    Found in src/Connection.php - About 5 hrs to fix

      Method getUpdateExtendedPropertySQL has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                              $name,
                        $value = null,
                        $level0Type = null,
                        $level0Name = null,
                        $level1Type = null,
      Severity: Major
      Found in src/Connection.php - About 1 hr to fix

        Method getAddExtendedPropertySQL has 8 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                                $name,
                        $value = null,
                        $level0Type = null,
                        $level0Name = null,
                        $level1Type = null,
        Severity: Major
        Found in src/Connection.php - About 1 hr to fix

          Function connectDbalConnection has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              protected static function connectDbalConnection(array $dsn)
    {
        if (isset($dsn['pdo'])) {
            $pdo = $dsn['pdo'];
        } else {
          Severity: Minor
          Found in src/Connection.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method getDropExtendedPropertySQL has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                                  $name,
                        $level0Type = null,
                        $level0Name = null,
                        $level1Type = null,
                        $level1Name = null,
          Severity: Major
          Found in src/Connection.php - About 50 mins to fix

            Function normalizeDsn has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function normalizeDsn($dsn, $user = null, $pass = null)
    {
        // Try to dissect DSN into parts
        $parts = is_array($dsn) ? $dsn : parse_url($dsn);
            Severity: Minor
            Found in src/Connection.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function forwardTypeDeclarationSQL has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                                private function forwardTypeDeclarationSQL(string $targetMethodName, array $column): string
                    {
                        $backtrace = debug_backtrace(\DEBUG_BACKTRACE_PROVIDE_OBJECT | \DEBUG_BACKTRACE_IGNORE_ARGS);
                        foreach ($backtrace as $frame) {
                            if ($this === ($frame['object'] ?? null)
            Severity: Minor
            Found in src/Connection.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                public function getUpdateExtendedPropertySQL(
                        $name,
                        $value = null,
                        $level0Type = null,
                        $level0Name = null,
            Severity: Major
            Found in src/Connection.php and 1 other location - About 7 hrs to fix
            src/Connection.php on lines 328..350

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 224.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                public function getAddExtendedPropertySQL(
                        $name,
                        $value = null,
                        $level0Type = null,
                        $level0Name = null,
            Severity: Major
            Found in src/Connection.php and 1 other location - About 7 hrs to fix
            src/Connection.php on lines 375..397

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 224.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                protected function getAlterColumnCommentSQL($tableName, $columnName, $comment)
                    {
                        if (strpos($tableName, '.') !== false) {
                            [$schemaName, $tableName] = explode('.', $tableName, 2);
                        } else {
            Severity: Major
            Found in src/Connection.php and 1 other location - About 1 hr to fix
            src/Connection.php on lines 264..282

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 110.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                protected function getCreateColumnCommentSQL($tableName, $columnName, $comment)
                    {
                        if (strpos($tableName, '.') !== false) {
                            [$schemaName, $tableName] = explode('.', $tableName, 2);
                        } else {
            Severity: Major
            Found in src/Connection.php and 1 other location - About 1 hr to fix
            src/Connection.php on lines 284..302

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 110.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status