Sign upLogin

atk4/ui

View on GitHub
Star
src/Behat/CoverageUtil.php

Summary

Maintainability
A
0 mins
Test Coverage

saveData accesses the super-global variable $_SERVER.
Open

    public static function saveData(string $outputDir): void
    {
        $outputFile = $outputDir . '/' . basename($_SERVER['SCRIPT_NAME'] ?? 'unknown', '.php') . '-' . hash('sha256', microtime(true) . random_bytes(64)) . '.cov';

        self::$coverage->stop();
Severity: Minor
Found in src/Behat/CoverageUtil.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Missing class import via use statement (line '25', column '23').
Open

            throw new \Error('Coverage already started');
Severity: Minor
Found in src/Behat/CoverageUtil.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

The method listFiles uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $res[] = $path;
            }
Severity: Minor
Found in src/Behat/CoverageUtil.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid excessively long variable names like $phpunitCoverageConfig. Keep variable name length under 20.
Open

        $phpunitCoverageConfig = simplexml_load_file($phpunitConfigDir . '/phpunit.xml.dist')->source;
Severity: Minor
Found in src/Behat/CoverageUtil.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Line exceeds 120 characters; contains 164 characters
Open

        $outputFile = $outputDir . '/' . basename($_SERVER['SCRIPT_NAME'] ?? 'unknown', '.php') . '-' . hash('sha256', microtime(true) . random_bytes(64)) . '.cov';
Severity: Minor
Found in src/Behat/CoverageUtil.php by phpcodesniffer

There are no issues that match your filters.

Category
Status