Sign upLogin

atk4/ui

View on GitHub
Star
src/Callback.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$object'.
Open

    public function add(AbstractView $object, array $args = []): AbstractView
Severity: Minor
Found in src/Callback.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$args'.
Open

    public function add(AbstractView $object, array $args = []): AbstractView
Severity: Minor
Found in src/Callback.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid variables with short names like $fx. Configured minimum length is 3.
Open

    public function set($fx = null, $fxArgs = null)
Severity: Minor
Found in src/Callback.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Line exceeds 120 characters; contains 124 characters
Open

                // catch and wrap an exception using a custom Error class to prevent "Callback requested, but never reached"
Severity: Minor
Found in src/Callback.php by phpcodesniffer

Line exceeds 120 characters; contains 164 characters
Open

        return $this->getApp()->hasRequestQueryParam(self::URL_QUERY_TARGET) && $this->getApp()->getRequestQueryParam(self::URL_QUERY_TARGET) === $this->urlTrigger;
Severity: Minor
Found in src/Callback.php by phpcodesniffer

Line exceeds 120 characters; contains 133 characters
Open

            self::URL_QUERY_TRIGGER_PREFIX . $this->urlTrigger => $value ?? ($this->isTriggered() ? $this->getTriggeredValue() : ''),
Severity: Minor
Found in src/Callback.php by phpcodesniffer

There are no issues that match your filters.

Category
Status