Sign upLogin

atk4/ui

View on GitHub
Star
src/Form/Control.php

Summary

Maintainability
A
0 mins
Test Coverage

The method jsInput has a boolean flag argument $when, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function jsInput($when = false, $action = null): ?JsExpressionable
Severity: Minor
Found in src/Form/Control.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method set uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $this->content = $value;
        }
Severity: Minor
Found in src/Form/Control.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Line exceeds 120 characters; contains 161 characters
Open

 * @phpstan-type JsCallbackSetClosure \Closure(Jquery, mixed, mixed, mixed, mixed, mixed, mixed, mixed, mixed, mixed, mixed): (JsExpressionable|View|string|void)
Severity: Minor
Found in src/Form/Control.php by phpcodesniffer

There are no issues that match your filters.

Category
Status