Sign upLogin

atroo/node-weedfs

View on GitHub
Star

Showing 8 of 8 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    masterStatus: function () {
        var self = this;
        return new Promise(function (resolve, reject) {
            var req = http.request(url.parse(self.baseURL + "cluster/status"), function (res) {
                let body = "";
Severity: Major
Found in lib/weedfs.js and 1 other location - About 1 day to fix
lib/weedfs.js on lines 149..177

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 243.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    clusterStatus: function () {
        var self = this;
        return new Promise(function (resolve, reject) {
            var req = http.request(url.parse(self.baseURL + "cluster/status"), function (res) {
                let body = "";
Severity: Major
Found in lib/weedfs.js and 1 other location - About 1 day to fix
lib/weedfs.js on lines 179..207

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 243.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File weedfs.js has 348 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";

var qs = require('querystring');
var fs = require('fs');
var path = require('path');
Severity: Minor
Found in lib/weedfs.js - About 4 hrs to fix

    Function write has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        write: function (file, opts) {
        opts = opts || {};
        var self = this;
        if (file instanceof Array) {
            opts.count = file.length;
    Severity: Major
    Found in lib/weedfs.js - About 2 hrs to fix

      Function read has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          read: function (fid, stream, opts) {
        var self = this;

        return self.find(fid, opts).then(function (res) {
            return new Promise(function (resolve, reject) {
      Severity: Minor
      Found in lib/weedfs.js - About 1 hr to fix

        Function remove has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            remove: function (fid, opts) {
        var self = this;

        return self.find(fid, opts).then(function (result) {
            return new Promise(function (resolve, reject) {
        Severity: Minor
        Found in lib/weedfs.js - About 1 hr to fix

          Function find has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              find: function (fid, opts) {
        let self = this;
        return new Promise(function (resolve, reject) {
            let options = Object.assign({}, url.parse(self.baseURL + "dir/lookup?volumeId=" + fid));
            if (opts && opts.collection) {
          Severity: Minor
          Found in lib/weedfs.js - About 1 hr to fix

            Function write has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                write: function (file, opts) {
        opts = opts || {};
        var self = this;
        if (file instanceof Array) {
            opts.count = file.length;
            Severity: Minor
            Found in lib/weedfs.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language