atsid/ultra-throttle

View on GitHub

Showing 8 of 8 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('will 0 when the clock has expired', () => {
        const bucket = { createdAt: new Date(0) };
        clock.tick(1000);
        const ttl = getTimeUntilReset(bucket, 1);
        expect(ttl).to.equal(0);
Severity: Major
Found in src/getTimeUntilReset.test.js and 1 other location - About 1 hr to fix
src/getTimeUntilReset.test.js on lines 33..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('will emit 0 when the clock has run over', () => {
        const bucket = { createdAt: new Date(0) };
        clock.tick(2000);
        const ttl = getTimeUntilReset(bucket, 1);
        expect(ttl).to.equal(0);
Severity: Major
Found in src/getTimeUntilReset.test.js and 1 other location - About 1 hr to fix
src/getTimeUntilReset.test.js on lines 26..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function initialize(conf) {
    const config = new Configuration(conf);
    const RateBucket = model.initialize(config);
    const bucketManager = new BucketManager(RateBucket);
    const ttl = config.ttl;
Severity: Minor
Found in src/index.js - About 1 hr to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it('will emit 0 when the bucket has been consumed', () => {
            const bucket = { hits: 100 };
            const remaining = getHitsRemaining(bucket, 100);
            expect(remaining).to.equal(0);
        });
    Severity: Major
    Found in src/getHitsRemaining.test.js and 3 other locations - About 1 hr to fix
    src/getHitsRemaining.test.js on lines 7..11
    src/getHitsRemaining.test.js on lines 13..17
    src/getHitsRemaining.test.js on lines 25..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it('will emit a partial number of hits remaining in the bucket', () => {
            const bucket = { hits: 25 };
            const remaining = getHitsRemaining(bucket, 100);
            expect(remaining).to.equal(75);
        });
    Severity: Major
    Found in src/getHitsRemaining.test.js and 3 other locations - About 1 hr to fix
    src/getHitsRemaining.test.js on lines 7..11
    src/getHitsRemaining.test.js on lines 19..23
    src/getHitsRemaining.test.js on lines 25..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it('will emit the full number of hits remaining in the bucket', () => {
            const bucket = { hits: 0 };
            const remaining = getHitsRemaining(bucket, 100);
            expect(remaining).to.equal(100);
        });
    Severity: Major
    Found in src/getHitsRemaining.test.js and 3 other locations - About 1 hr to fix
    src/getHitsRemaining.test.js on lines 13..17
    src/getHitsRemaining.test.js on lines 19..23
    src/getHitsRemaining.test.js on lines 25..29

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        it('will emit a zero when the bucket has overrun', () => {
            const bucket = { hits: 1000 };
            const remaining = getHitsRemaining(bucket, 100);
            expect(remaining).to.equal(0);
        });
    Severity: Major
    Found in src/getHitsRemaining.test.js and 3 other locations - About 1 hr to fix
    src/getHitsRemaining.test.js on lines 7..11
    src/getHitsRemaining.test.js on lines 13..17
    src/getHitsRemaining.test.js on lines 19..23

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function schema has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function schema(config) {
        debug(`throttles will expire with ttl ${config.ttl}`);
        return {
            name: {
                type: String,
    Severity: Minor
    Found in src/model/definition.js - About 1 hr to fix
      Severity
      Category
      Status
      Source
      Language