Sign upLogin

aureooms/js-median

View on GitHub
Star

Showing 5 of 5 total issues

Function cond6 has a Cognitive Complexity of 321 (exceeds 5 allowed). Consider refactoring.
Open

const cond6 = function ( compare , A , i ) {

    const _a = i ; const _b = ++i ; const _c = ++i ;
    const _d = ++i ; const _e = ++i ;
Severity: Minor
Found in js/src/$5/cond6.js - About 6 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

         : compare( d , c ) < 0 ? compare( a , d ) < 0 ? compare( b , e ) < 0 ? compare( b , d ) < 0 ? compare( e , d ) < 0 ? _e : _d
         : compare( c , b ) < 0 ? _c : _b
         : compare( e , d ) < 0 ? compare( b , d ) < 0 ? _b : _d
         : compare( c , e ) < 0 ? _c : _e
         : compare( c , e ) < 0 ? compare( a , c ) < 0 ? compare( b , c ) < 0 ? _b : _c
Severity: Major
Found in js/src/$5/cond6.js and 1 other location - About 2 days to fix
js/src/$5/cond6.js on lines 10..29

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 466.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

           compare( d , c ) < 0 ?
           compare( b , d ) < 0 ?
           compare( a , e ) < 0 ?
           compare( a , d ) < 0 ?
           compare( e , d ) < 0 ? _e : _d
Severity: Major
Found in js/src/$5/cond6.js and 1 other location - About 2 days to fix
js/src/$5/cond6.js on lines 30..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 466.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function cond6 has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const cond6 = function ( compare , A , i ) {

    const _a = i ; const _b = ++i ; const _c = ++i ;
    const _d = ++i ; const _e = ++i ;
Severity: Minor
Found in js/src/$5/cond6.js - About 1 hr to fix

    Function clear has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    const clear = function ( compare , A , i ) {

    let _a = i ; let _b = ++i ; let _c = ++i ;
    let _d = ++i ; const _e = ++i ;
    Severity: Minor
    Found in js/src/$5/clear.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language