aureooms/js-sat

View on GitHub

Showing 13 of 13 total issues

Function _parse_DIMACS_CNF has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

export default function _parse_DIMACS_CNF(iterable) {
    const iterator = iterable[Symbol.iterator]();

    const clauses = [];

Severity: Minor
Found in src/core/parse/_parse_DIMACS_CNF.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _parse_DIMACS_CNF has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function _parse_DIMACS_CNF(iterable) {
    const iterator = iterable[Symbol.iterator]();

    const clauses = [];

Severity: Minor
Found in src/core/parse/_parse_DIMACS_CNF.js - About 1 hr to fix

    Function _keys_to_parity has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function _keys_to_parity(clauses) {
        const keys = new Map();
        const variables = [];
    
        const instance = [];
    Severity: Minor
    Found in src/core/convert/_keys_to_parity.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function update_watchlist has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function update_watchlist(watchlist, false_literal, assignment) {
        while (watchlist[false_literal].length > 0) {
            const clause =
                watchlist[false_literal][watchlist[false_literal].length - 1];
            let found_alternative = false;
    Severity: Minor
    Found in src/core/SAT0W/update_watchlist.js - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function SAT0W has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    export default function* SAT0W(n, clauses, watchlist, assignment, d) {
    Severity: Minor
    Found in src/core/SAT0W/SAT0W.js - About 35 mins to fix

      Function _verify has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export default function _verify(clauses, assignment) {
          // eslint-disable-next-line no-labels
          loop: for (const clause of clauses) {
              for (const literal of clause) {
                  // eslint-disable-next-line no-labels
      Severity: Minor
      Found in src/core/_verify.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _parse_int has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      export default function _parse_int(first_symbol, iterator) {
          let i = 0;
          let s = 1;
      
          if (first_symbol === '-') s = -1;
      Severity: Minor
      Found in src/core/parse/_parse_int.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          while (true) {
              const current = iterator.next();
      
              if (current.done) return clauses;
      
      
      Severity: Minor
      Found in src/core/parse/_parse_DIMACS_CNF.js and 1 other location - About 35 mins to fix
      src/core/parse/_parse_DIMACS_CNF.js on lines 26..33

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              while (true) {
                  const current = iterator.next();
      
                  if (current.done) return clauses;
      
      
      Severity: Minor
      Found in src/core/parse/_parse_DIMACS_CNF.js and 1 other location - About 35 mins to fix
      src/core/parse/_parse_DIMACS_CNF.js on lines 39..46

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          constructor(clauses) {
              /** @member {number[][]} The clauses in parity format. */
              this.clauses = clauses;
              /** @member {number} The number of variables in this instance. */
              this.n = _count(clauses);
      Severity: Minor
      Found in src/core/convert/SignsInstance.js and 1 other location - About 30 mins to fix
      src/core/convert/ParitiesInstance.js on lines 12..17

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

                      if (done2) return clauses;
      Severity: Major
      Found in src/core/parse/_parse_DIMACS_CNF.js - About 30 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            constructor(clauses) {
                /** @member {number[][]} The clauses in parity format. */
                this.clauses = clauses;
                /** @member {number} The number of variables in this instance. */
                this.n = _count(clauses);
        Severity: Minor
        Found in src/core/convert/ParitiesInstance.js and 1 other location - About 30 mins to fix
        src/core/convert/SignsInstance.js on lines 12..17

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

                        return clauses;
        Severity: Major
        Found in src/core/parse/_parse_DIMACS_CNF.js - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language