avocado-framework/avocado

View on GitHub
avocado/core/safeloader/core.py

Summary

Maintainability
D
2 days
Test Coverage
A
93%

Function _examine_class has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

def _examine_class(target_module, target_class, determine_match, path,
                   class_name, match):
    """
    Examine a class from a given path

Severity: Minor
Found in avocado/core/safeloader/core.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function find_python_tests has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

def find_python_tests(target_module, target_class, determine_match, path):
    """
    Attempts to find Python tests from source files

    A Python test in this context is a method within a specific type
Severity: Minor
Found in avocado/core/safeloader/core.py - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File core.py has 298 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import ast
import collections
import sys
from importlib.machinery import PathFinder

Severity: Minor
Found in avocado/core/safeloader/core.py - About 3 hrs to fix

    Function _get_attributes_for_further_examination has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    def _get_attributes_for_further_examination(parent, module):
        """Returns path, module and class for further examination.
    
        This looks at one of the parents of an interesting class, so for the
        example class Test below:
    Severity: Minor
    Found in avocado/core/safeloader/core.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _examine_same_module has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def _examine_same_module(parents, info, disabled, match, module,
    Severity: Major
    Found in avocado/core/safeloader/core.py - About 1 hr to fix

      Function get_methods_info has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

      def get_methods_info(statement_body, class_tags, class_requirements):
          """Returns information on test methods.
      
          :param statement_body: the body of a "class" statement
          :param class_tags: the tags at the class level, to be combined with the
      Severity: Minor
      Found in avocado/core/safeloader/core.py - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _examine_class has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def _examine_class(target_module, target_class, determine_match, path,
      Severity: Minor
      Found in avocado/core/safeloader/core.py - About 45 mins to fix

        Function _examine_same_module has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        def _examine_same_module(parents, info, disabled, match, module,
                                 target_module, target_class, determine_match):
            # Searching the parents in the same module
            for parent in parents[:]:
                # Looking for a 'class FooTest(Parent)'
        Severity: Minor
        Found in avocado/core/safeloader/core.py - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    try:
                        (parent_class,
                         imported_symbol,
                         symbol_is_module) = _get_attributes_for_further_examination(parent,
                                                                                     module)
        Severity: Major
        Found in avocado/core/safeloader/core.py and 1 other location - About 1 hr to fix
        avocado/core/safeloader/core.py on lines 358..368

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    try:
                        (parent_class,
                         imported_symbol,
                         symbol_is_module) = _get_attributes_for_further_examination(parent,
                                                                                     module)
        Severity: Major
        Found in avocado/core/safeloader/core.py and 1 other location - About 1 hr to fix
        avocado/core/safeloader/core.py on lines 239..249

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status