avocado-framework/avocado

View on GitHub
selftests/functional/test_lv_utils.py

Summary

Maintainability
A
35 mins
Test Coverage

Function call with shell=True parameter identified, possible security issue.
Open

    @unittest.skipIf(process.system("modinfo scsi_debug", shell=True,
                                    ignore_status=True),

Function call with shell=True parameter identified, possible security issue.
Open

    @unittest.skipIf(process.system("vgs --all | grep -q avocado_testing_vg_"
                                    "e5kj3erv11a; [ $? -ne 0 ]", sudo=True,
                                    shell=True, ignore_status=True),

Function call with shell=True parameter identified, possible security issue.
Open

                process.run("mountpoint %s && umount %s"
                            % (mount_loc, mount_loc), shell=True, sudo=True)

Function test_basic_workflow has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def test_basic_workflow(self):
        """
        Check the basic workflow works using ramdisk
        """
        ramdisk_filename = vg_ramdisk_dir = loop_device = None
Severity: Minor
Found in selftests/functional/test_lv_utils.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status