avocado-framework/avocado

View on GitHub
selftests/functional/test_skiptests.py

Summary

Maintainability
D
2 days
Test Coverage

File test_skiptests.py has 281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import json
import os
import unittest

from avocado.core import exit_codes
Severity: Minor
Found in selftests/functional/test_skiptests.py - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def _get_json_result(self):
            cmd_line = [AVOCADO,
                        'run',
                        '--disable-sysinfo',
                        '--job-results-dir',
    Severity: Major
    Found in selftests/functional/test_skiptests.py and 1 other location - About 6 hrs to fix
    selftests/functional/test_skiptests.py on lines 273..284

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def _get_json_result(self):
            cmd_line = [AVOCADO,
                        'run',
                        '--disable-sysinfo',
                        '--job-results-dir',
    Severity: Major
    Found in selftests/functional/test_skiptests.py and 1 other location - About 6 hrs to fix
    selftests/functional/test_skiptests.py on lines 378..389

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 101.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    class SkipUnlessClass(Base):
    
        FILE_NAME_CONTENT_MAP = {
            'lib_skip_decorators.py': AVOCADO_TEST_SKIP_LIB,
            'script_to_exec.py': AVOCADO_TEST_SKIP_UNLESS_CLASS_DECORATORS
    Severity: Major
    Found in selftests/functional/test_skiptests.py and 2 other locations - About 50 mins to fix
    selftests/functional/test_skiptests.py on lines 318..326
    selftests/functional/test_skiptests.py on lines 340..348

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    class NotSkip(Base):
    
        FILE_NAME_CONTENT_MAP = {
            'lib_skip_decorators.py': AVOCADO_TEST_SKIP_LIB,
            'script_to_exec.py': AVOCADO_TEST_NOT_SKIP_DECORATORS
    Severity: Major
    Found in selftests/functional/test_skiptests.py and 2 other locations - About 50 mins to fix
    selftests/functional/test_skiptests.py on lines 340..348
    selftests/functional/test_skiptests.py on lines 351..359

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

    class SkipIfClass(Base):
    
        FILE_NAME_CONTENT_MAP = {
            'lib_skip_decorators.py': AVOCADO_TEST_SKIP_LIB,
            'script_to_exec.py': AVOCADO_TEST_SKIP_IF_CLASS_DECORATORS
    Severity: Major
    Found in selftests/functional/test_skiptests.py and 2 other locations - About 50 mins to fix
    selftests/functional/test_skiptests.py on lines 318..326
    selftests/functional/test_skiptests.py on lines 351..359

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status