avocado-framework/avocado

View on GitHub
selftests/unit/plugin/test_xunit.py

Summary

Maintainability
A
2 hrs
Test Coverage

Using xml.dom.minidom.parseString to parse untrusted XML data is known to be vulnerable to XML attacks. Replace xml.dom.minidom.parseString with its defusedxml equivalent function or make sure defusedxml.defuse_stdlib() is called
Open

            dom = minidom.parseString(xml)
Severity: Minor
Found in selftests/unit/plugin/test_xunit.py by bandit

Using minidom to parse untrusted XML data is known to be vulnerable to XML attacks. Replace minidom with the equivalent defusedxml package, or make sure defusedxml.defuse_stdlib() is called.
Open

from xml.dom import minidom

Function test_max_test_log_size has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def test_max_test_log_size(self):
        def get_system_out(out):
            return out[out.find(b"<system-out>"):out.find(b"<system-out/>")]
        log = tempfile.NamedTemporaryFile(dir=self.tmpdir.name, delete=False)
        log_content = b"1234567890" * 100
Severity: Minor
Found in selftests/unit/plugin/test_xunit.py - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            try:
                dom = minidom.parseString(xml)
            except Exception as details:
                raise ParseXMLError("Error parsing XML: '%s'.\nXML Contents:\n%s" % (details, xml))
    Severity: Minor
    Found in selftests/unit/plugin/test_xunit.py and 1 other location - About 50 mins to fix
    selftests/functional/test_basic.py on lines 1208..1212

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status