avocado-framework/avocado

View on GitHub
selftests/unit/test_safeloader_core.py

Summary

Maintainability
D
1 day
Test Coverage

File test_safeloader_core.py has 272 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import os
import sys
import unittest
import unittest.mock
from collections import OrderedDict
Severity: Minor
Found in selftests/unit/test_safeloader_core.py - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def test_relative_level0_from_level2(self):
            path = os.path.join(self.tmpdir.name, 'l1', 'l2', 'l2lib2.py')
            self.assertEqual(find_avocado_tests(path)[0],
                             {'BaseL2': [('test_l2', {}, []),
                                         ('test_l0', {}, [])]})
    Severity: Major
    Found in selftests/unit/test_safeloader_core.py and 1 other location - About 2 hrs to fix
    selftests/unit/test_safeloader_core.py on lines 316..320

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def test_relative_level0_name_from_level2(self):
            path = os.path.join(self.tmpdir.name, 'l1', 'l2', 'l2lib1.py')
            self.assertEqual(find_avocado_tests(path)[0],
                             {'BaseL2': [('test_l2', {}, []),
                                         ('test_l0', {}, [])]})
    Severity: Major
    Found in selftests/unit/test_safeloader_core.py and 1 other location - About 2 hrs to fix
    selftests/unit/test_safeloader_core.py on lines 322..326

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def test_relative_level0_from_level1(self):
            path = os.path.join(self.tmpdir.name, 'l1', 'l1lib2.py')
            self.assertEqual(find_avocado_tests(path)[0],
                             {'BaseL1': [('test_l1', {}, []),
                                         ('test_l0', {}, [])]})
    Severity: Major
    Found in selftests/unit/test_safeloader_core.py and 1 other location - About 2 hrs to fix
    selftests/unit/test_safeloader_core.py on lines 304..308

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def test_relative_level0_name_from_level1(self):
            path = os.path.join(self.tmpdir.name, 'l1', 'l1lib1.py')
            self.assertEqual(find_avocado_tests(path)[0],
                             {'BaseL1': [('test_l1', {}, []),
                                         ('test_l0', {}, [])]})
    Severity: Major
    Found in selftests/unit/test_safeloader_core.py and 1 other location - About 2 hrs to fix
    selftests/unit/test_safeloader_core.py on lines 310..314

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status