avocado-framework/avocado

View on GitHub
selftests/unit/test_safeloader_docstring.py

Summary

Maintainability
C
1 day
Test Coverage

DocstringDirectives has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class DocstringDirectives(unittest.TestCase):

    VALID_DIRECTIVES = [":avocado: foo",
                        " :avocado: foo",
                        " :avocado: foo ",
Severity: Minor
Found in selftests/unit/test_safeloader_docstring.py - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def test_tag_keyval_duplicate(self):
            raw = ":avocado: tags=fast,arch:x86_64,arch:ppc64,arch:x86_64"
            exp = {"fast": None, "arch": set(["x86_64", "ppc64"])}
            self.assertEqual(get_docstring_directives_tags(raw), exp)
    Severity: Major
    Found in selftests/unit/test_safeloader_docstring.py and 1 other location - About 1 hr to fix
    selftests/unit/test_safeloader_docstring.py on lines 135..138

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def test_tag_keyval_double(self):
            raw = ":avocado: tags=fast,arch:x86_64,arch:ppc64"
            exp = {"fast": None, "arch": set(["x86_64", "ppc64"])}
            self.assertEqual(get_docstring_directives_tags(raw), exp)
    Severity: Major
    Found in selftests/unit/test_safeloader_docstring.py and 1 other location - About 1 hr to fix
    selftests/unit/test_safeloader_docstring.py on lines 140..143

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 43.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        def test_tag_double(self):
            raw = ":avocado: tags=fast,network"
            exp = {"fast": None, "network": None}
            self.assertEqual(get_docstring_directives_tags(raw), exp)
    Severity: Major
    Found in selftests/unit/test_safeloader_docstring.py and 4 other locations - About 50 mins to fix
    selftests/unit/test_safeloader_docstring.py on lines 95..98
    selftests/unit/test_safeloader_docstring.py on lines 100..103
    selftests/unit/test_safeloader_docstring.py on lines 105..108
    selftests/unit/test_safeloader_docstring.py on lines 125..128

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        def test_tag_double_with_empty(self):
            raw = ":avocado: tags=fast,,network"
            exp = {"fast": None, "network": None}
            self.assertEqual(get_docstring_directives_tags(raw), exp)
    Severity: Major
    Found in selftests/unit/test_safeloader_docstring.py and 4 other locations - About 50 mins to fix
    selftests/unit/test_safeloader_docstring.py on lines 90..93
    selftests/unit/test_safeloader_docstring.py on lines 100..103
    selftests/unit/test_safeloader_docstring.py on lines 105..108
    selftests/unit/test_safeloader_docstring.py on lines 125..128

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        def test_tag_newline_after(self):
            raw = ":avocado: tags=fast,slow\n:avocado: enable"
            exp = {"fast": None, "slow": None}
            self.assertEqual(get_docstring_directives_tags(raw), exp)
    Severity: Major
    Found in selftests/unit/test_safeloader_docstring.py and 4 other locations - About 50 mins to fix
    selftests/unit/test_safeloader_docstring.py on lines 90..93
    selftests/unit/test_safeloader_docstring.py on lines 95..98
    selftests/unit/test_safeloader_docstring.py on lines 100..103
    selftests/unit/test_safeloader_docstring.py on lines 105..108

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        def test_tag_lowercase_uppercase(self):
            raw = ":avocado: tags=slow,DISK"
            exp = {"slow": None, "DISK": None}
            self.assertEqual(get_docstring_directives_tags(raw), exp)
    Severity: Major
    Found in selftests/unit/test_safeloader_docstring.py and 4 other locations - About 50 mins to fix
    selftests/unit/test_safeloader_docstring.py on lines 90..93
    selftests/unit/test_safeloader_docstring.py on lines 95..98
    selftests/unit/test_safeloader_docstring.py on lines 105..108
    selftests/unit/test_safeloader_docstring.py on lines 125..128

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

        def test_tag_duplicate(self):
            raw = ":avocado: tags=SLOW,disk,disk"
            exp = {"SLOW": None, "disk": None}
            self.assertEqual(get_docstring_directives_tags(raw), exp)
    Severity: Major
    Found in selftests/unit/test_safeloader_docstring.py and 4 other locations - About 50 mins to fix
    selftests/unit/test_safeloader_docstring.py on lines 90..93
    selftests/unit/test_safeloader_docstring.py on lines 95..98
    selftests/unit/test_safeloader_docstring.py on lines 100..103
    selftests/unit/test_safeloader_docstring.py on lines 125..128

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 36.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        def test_tag_tab_separator(self):
            raw = ":avocado:\ttags=FAST"
            exp = {"FAST": None}
            self.assertEqual(get_docstring_directives_tags(raw), exp)
    Severity: Major
    Found in selftests/unit/test_safeloader_docstring.py and 2 other locations - About 40 mins to fix
    selftests/unit/test_safeloader_docstring.py on lines 85..88
    selftests/unit/test_safeloader_docstring.py on lines 120..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        def test_tag_newline_before(self):
            raw = ":avocado: enable\n:avocado: tags=fast"
            exp = {"fast": None}
            self.assertEqual(get_docstring_directives_tags(raw), exp)
    Severity: Major
    Found in selftests/unit/test_safeloader_docstring.py and 2 other locations - About 40 mins to fix
    selftests/unit/test_safeloader_docstring.py on lines 85..88
    selftests/unit/test_safeloader_docstring.py on lines 110..113

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        def test_tag_single(self):
            raw = ":avocado: tags=fast"
            exp = {"fast": None}
            self.assertEqual(get_docstring_directives_tags(raw), exp)
    Severity: Major
    Found in selftests/unit/test_safeloader_docstring.py and 2 other locations - About 40 mins to fix
    selftests/unit/test_safeloader_docstring.py on lines 110..113
    selftests/unit/test_safeloader_docstring.py on lines 120..123

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status