avocado-framework/avocado

View on GitHub
selftests/unit/utils/test_vmimage.py

Summary

Maintainability
D
2 days
Test Coverage

File test_vmimage.py has 353 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import unittest.mock
from urllib.error import HTTPError

from avocado.utils import vmimage
from selftests.utils import setup_avocado_loggers
Severity: Minor
Found in selftests/unit/utils/test_vmimage.py - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @unittest.mock.patch('avocado.utils.vmimage.urlopen')
        def test_get_version_with_float_versions(self, urlopen_mock):
            html_fixture = self.get_html_with_versions([10.1, 10.3, 10.2])
            urlread_mocked = unittest.mock.Mock(return_value=html_fixture)
            urlopen_mock.return_value = unittest.mock.Mock(read=urlread_mocked)
    Severity: Major
    Found in selftests/unit/utils/test_vmimage.py and 1 other location - About 5 hrs to fix
    selftests/unit/utils/test_vmimage.py on lines 59..65

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        @unittest.mock.patch('avocado.utils.vmimage.urlopen')
        def test_get_version(self, urlopen_mock):
            html_fixture = self.get_html_with_versions([10, 11, 12])
            urlread_mocked = unittest.mock.Mock(return_value=html_fixture)
            urlopen_mock.return_value = unittest.mock.Mock(read=urlread_mocked)
    Severity: Major
    Found in selftests/unit/utils/test_vmimage.py and 1 other location - About 5 hrs to fix
    selftests/unit/utils/test_vmimage.py on lines 67..73

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 97.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status