avocado-framework/avocado

View on GitHub
setup.py

Summary

Maintainability
B
6 hrs
Test Coverage

subprocess call - check for execution of untrusted input.
Open

            run([cmd, "man/avocado.rst", "man/avocado.1"], check=True)
Severity: Info
Found in setup.py by bandit

Probable insecure usage of temp file/directory.
Open

        cleaning_list += list(Path('/var/tmp/').glob(".avocado-*"))
Severity: Minor
Found in setup.py by bandit

subprocess call - check for execution of untrusted input.
Open

            run([sys.executable, "setup.py"] + action, cwd=parent_dir, check=True)
Severity: Info
Found in setup.py by bandit

subprocess call - check for execution of untrusted input.
Open

        run(["/usr/bin/make", "develop"], check=True)
Severity: Info
Found in setup.py by bandit

Consider possible security implications associated with CalledProcessError module.
Open

from subprocess import CalledProcessError, run

Severity: Info
Found in setup.py by bandit

subprocess call - check for execution of untrusted input.
Open

        run([sys.executable, "setup.py"] + action, cwd=parent_dir, check=True)
Severity: Info
Found in setup.py by bandit

Probable insecure usage of temp file/directory.
Open

        cleaning_list += list(Path('/tmp/').glob(".avocado-*"))
Severity: Minor
Found in setup.py by bandit

File setup.py has 362 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#!/bin/env python3
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
Severity: Minor
Found in setup.py - About 4 hrs to fix

    Function run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def run(self):
    
            plugins_list = []
            directory = os.path.join(BASE_PATH, "optional_plugins")
            for plugin in list(Path(directory).glob("*/setup.py")):
    Severity: Minor
    Found in setup.py - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def run(self):
            super().run()
            cleaning_list = ["MANIFEST", "BUILD", "BUILDROOT", "SPECS",
                             "RPMS", "SRPMS", "SOURCES", "PYPI_UPLOAD",
                             "./build", "./dist",
    Severity: Minor
    Found in setup.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    with open(os.path.join(BASE_PATH, 'VERSION'), 'r') as version_file:
        VERSION = version_file.read().strip()
    Severity: Minor
    Found in setup.py and 1 other location - About 35 mins to fix
    avocado/plugins/diff.py on lines 372..373

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status