awsmug/torro-forms-plugin-boilerplate

View on GitHub
src/element-types/date.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method filter_json has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function filter_json( $data, $element, $submission = null ) {
        global $wp_locale;

        $data = parent::filter_json( $data, $element, $submission );

Severity: Minor
Found in src/element-types/date.php - About 1 hr to fix

    Function validate_field has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        public function validate_field( $value, $element, $submission ) {
            $settings = $this->get_settings( $element );
    
            // Support Y-m-d string passed, just so that submission editing with single field works too.
            if ( is_string( $value ) && 2 === substr_count( $value, '-' ) ) {
    Severity: Minor
    Found in src/element-types/date.php - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return $parsed_value;
    Severity: Major
    Found in src/element-types/date.php - About 30 mins to fix

      Function detect_date_fields_order has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function detect_date_fields_order() {
              $date_format = get_option( 'date_format' );
              $date_format = str_split( $date_format );
      
              $year_group  = array( 'Y', 'y' );
      Severity: Minor
      Found in src/element-types/date.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method validate_field() has an NPath complexity of 5400. The configured NPath complexity threshold is 200.
      Open

          public function validate_field( $value, $element, $submission ) {
              $settings = $this->get_settings( $element );
      
              // Support Y-m-d string passed, just so that submission editing with single field works too.
              if ( is_string( $value ) && 2 === substr_count( $value, '-' ) ) {
      Severity: Minor
      Found in src/element-types/date.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method validate_field() has a Cyclomatic Complexity of 18. The configured cyclomatic complexity threshold is 10.
      Open

          public function validate_field( $value, $element, $submission ) {
              $settings = $this->get_settings( $element );
      
              // Support Y-m-d string passed, just so that submission editing with single field works too.
              if ( is_string( $value ) && 2 === substr_count( $value, '-' ) ) {
      Severity: Minor
      Found in src/element-types/date.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Avoid unused parameters such as '$submission'.
      Open

          public function validate_field( $value, $element, $submission ) {
      Severity: Minor
      Found in src/element-types/date.php by phpmd

      UnusedFormalParameter

      Since: 0.2

      Avoid passing parameters to methods or constructors and then not using those parameters.

      Example

      class Foo
      {
          private function bar($howdy)
          {
              // $howdy is not used
          }
      }

      Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

      There are no issues that match your filters.

      Category
      Status