Sign upLogin

azukiapp/azk

View on GitHub
Star
src/agent/configure.js

Summary

Maintainability
D
1 day
Test Coverage

File configure.js has 393 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { _, t, os, log, lazy_require, fsAsync } from 'azk';
import { publish } from 'azk/utils/postal';
import { async, promisify, thenAll, promiseResolve } from 'azk/utils/promises';
import { config, set_config } from 'azk';
import { UIProxy } from 'azk/cli/ui';
Severity: Minor
Found in src/agent/configure.js - About 5 hrs to fix

    Configure has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export class Configure extends UIProxy {
  constructor(user_interface) {
    super(user_interface);
    this.dns_tab   = ports_tabs[os.platform()];
    this.docker_ip = null;
    Severity: Minor
    Found in src/agent/configure.js - About 2 hrs to fix

      Function _checkAzkVersion has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _checkAzkVersion() {
    return async(this, function* () {
      try {
        // check connectivity
        var currentOnline = yield net.isOnlineCheck();
      Severity: Minor
      Found in src/agent/configure.js - About 1 hr to fix

        Function _checkDockerVersion has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _checkDockerVersion(force = null) {
    var versions = {
      required: config('docker:min_version'),
      current : force || config('docker:version'),
    };
        Severity: Minor
        Found in src/agent/configure.js - About 1 hr to fix

          Function linux has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            linux() {
    if (config('agent:requires_vm')) {
      return this._checksForRequiresVm();
    } else {
      var socket = config('docker:socket');
          Severity: Minor
          Found in src/agent/configure.js - About 1 hr to fix

            Function _getNetworkIp has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              _getNetworkIp(suggestion) {
    var question = {
      name    : 'ip',
      message : 'configure.ip_question',
      // default : config('agent:vm:ip'),
            Severity: Minor
            Found in src/agent/configure.js - About 1 hr to fix

              Function _checkAndSaveIp has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                _checkAndSaveIp(nameserver, file, use_vm, services_ports) {
    return async(this, function* () {
      // Not exist or invalid content
      var dns_port = _.isObject(nameserver) ? nameserver.port : null;
      var unmatched_dns_port = dns_port !== services_ports.dns;
              Severity: Minor
              Found in src/agent/configure.js - About 1 hr to fix

                Function _getNetworkIp has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  _getNetworkIp(suggestion) {
    var question = {
      name    : 'ip',
      message : 'configure.ip_question',
      // default : config('agent:vm:ip'),
                Severity: Minor
                Found in src/agent/configure.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          } else if (!_.isEmpty(dns_port) && unmatched_dns_port) {
            fail_data = { file, old: nameserver.port, new: services_ports.dns };
            this.fail('configure.errors.unmatched_dns_port', fail_data);
          } else {
            this.warning('configure.vm_ip_msg');
                Severity: Minor
                Found in src/agent/configure.js and 1 other location - About 35 mins to fix
                src/agent/configure.js on lines 357..365

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          if (!_.isEmpty(conflict)) {
            fail_data = { ip, inter_name: conflict.name, inter_ip: conflict.ip };
            this.fail('configure.errors.invalid_current_ip', fail_data);
          } else if (!_.isEmpty(dns_port) && unmatched_dns_port) {
            fail_data = { file, old: nameserver.port, new: services_ports.dns };
                Severity: Minor
                Found in src/agent/configure.js and 1 other location - About 35 mins to fix
                src/agent/configure.js on lines 360..365

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status