Sign upLogin

backup/backup

View on GitHub
Star

Showing 79 of 79 total issues

Method perform has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    def perform
      check if options[:check] # this will exit()

      models = nil
      begin
Severity: Minor
Found in lib/backup/cli.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Model has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Model
    class Error < Backup::Error; end
    class FatalError < Backup::FatalError; end

    class << self
Severity: Minor
Found in lib/backup/model.rb - About 3 hrs to fix

    Method sync_in_threads has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

            def sync_in_threads(relative_paths, sync_block)
          queue = Queue.new
          queue << relative_paths.shift until relative_paths.empty?
          num_threads = [thread_count, queue.size].min
          Logger.info "\s\sUsing #{num_threads} Threads"
    Severity: Minor
    Found in lib/backup/syncer/cloud/base.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method perform has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def perform
      check if options[:check] # this will exit()

      models = nil
      begin
    Severity: Major
    Found in lib/backup/cli.rb - About 2 hrs to fix

      Method find_md5 has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

                def find_md5(dir, excludes)
            found = []
            (Dir.entries(dir) - %w[. ..]).map { |e| File.join(dir, e) }.each do |path|
              if File.directory?(path)
                unless exclude?(excludes, path)
      Severity: Minor
      Found in lib/backup/syncer/cloud/local_file.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method after_hook has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def after_hook
      return unless after && !@before_hook_failed

      Logger.info "After Hook Starting..."
      after.call(exit_status)
      Severity: Minor
      Found in lib/backup/model.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method perform! has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

            def perform!
        status =
          case model.exit_status
          when 0
            :success if notify_on_success?
      Severity: Minor
      Found in lib/backup/notifier/base.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method new_email has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def new_email
        method = %w[smtp sendmail exim file test]
          .index(@delivery_method.to_s) ? @delivery_method.to_s : "smtp"

        options =
      Severity: Minor
      Found in lib/backup/notifier/mail.rb - About 1 hr to fix

        Method run has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

              def run(command)
        name = command_name(command)
        Logger.info "Running system utility '#{name}'..."

        begin
        Severity: Minor
        Found in lib/backup/utilities.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method save! has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

              def save!
        resp = run("#{redis_cli_cmd} SAVE")
        unless resp =~ /OK$/
          raise Error, <<-EOS
            Failed to invoke the `SAVE` command
        Severity: Minor
        Found in lib/backup/database/redis.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method log! has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
        Open

            def log!(action)
      case action
      when :started
        Logger.info "Performing Backup for '#{label} (#{trigger})'!\n" \
            "[ backup #{VERSION} : #{RUBY_DESCRIPTION} ]"
        Severity: Minor
        Found in lib/backup/model.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method system_identifiers has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def system_identifiers
        @system_identifiers ||= begin
          skip_key = false
          data = run "#{utility(:gpg)} #{base_options} " \
            "--with-colons --fixed-list-mode --fingerprint"
        Severity: Minor
        Found in lib/backup/encryptor/gpg.rb - About 1 hr to fix

          Method upload_segments has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def upload_segments(src, dest, segment_bytes, file_size)
        total_segments = (file_size / segment_bytes.to_f).ceil
        progress = (0.1..0.9).step(0.1).map { |n| (total_segments * n).floor }
        Logger.info "\s\sUploading #{total_segments} SLO Segments..."
          Severity: Minor
          Found in lib/backup/cloud_io/cloud_files.rb - About 1 hr to fix

            Method attachment has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def attachment(status)
        {
          fallback: "#{title(status)} - Job: #{model.label} (#{model.trigger})",
          text: title(status),
          color: color(status),
            Severity: Minor
            Found in lib/backup/notifier/slack.rb - About 1 hr to fix

              Method procedure has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def procedure
        stack = []

        ##
        # Initial `tar` command to package the temporary backup folder.
              Severity: Minor
              Found in lib/backup/packager.rb - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def adjusted_chunk_bytes(chunk_bytes, file_size)
        return chunk_bytes if file_size / chunk_bytes.to_f <= 10_000

        mb = orig_mb = chunk_bytes / 1024**2
        mb += 1 until file_size / (1024**2 * mb).to_f <= 10_000
                Severity: Major
                Found in lib/backup/cloud_io/s3.rb and 1 other location - About 1 hr to fix
                lib/backup/cloud_io/cloud_files.rb on lines 256..268

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                      def adjusted_segment_bytes(segment_bytes, file_size)
        return segment_bytes if file_size / segment_bytes.to_f <= 1000

        mb = orig_mb = segment_bytes / 1024**2
        mb += 1 until file_size / (1024**2 * mb).to_f <= 1000
                Severity: Major
                Found in lib/backup/cloud_io/cloud_files.rb and 1 other location - About 1 hr to fix
                lib/backup/cloud_io/s3.rb on lines 215..227

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method prepare has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def prepare(model)
        messages = []

        packaging_folder = File.join(Config.tmp_path, model.trigger)
        if File.exist?(packaging_folder)
                Severity: Minor
                Found in lib/backup/cleaner.rb - About 1 hr to fix

                  Method upload_segments has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def upload_segments(src, dest, segment_bytes, file_size)
        total_segments = (file_size / segment_bytes.to_f).ceil
        progress = (0.1..0.9).step(0.1).map { |n| (total_segments * n).floor }
        Logger.info "\s\sUploading #{total_segments} SLO Segments..."
                  Severity: Minor
                  Found in lib/backup/cloud_io/cloud_files.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method new_email has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                        def new_email
        method = %w[smtp sendmail exim file test]
          .index(@delivery_method.to_s) ? @delivery_method.to_s : "smtp"

        options =
                  Severity: Minor
                  Found in lib/backup/notifier/mail.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language