Sign upLogin

barracudanetworks/jobrunner

View on GitHub
Star

Showing 7 of 63 total issues

Function canJobRun has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    protected function canJobRun($class)
    {
        $job_definition = $this->jobs[$class];
        if ($job_definition->getEnabled() == false)
        {
Severity: Minor
Found in src/JobRunner.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method canJobRun has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function canJobRun($class)
    {
        $job_definition = $this->jobs[$class];
        if ($job_definition->getEnabled() == false)
        {
Severity: Minor
Found in src/JobRunner.php - About 1 hr to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct($class_name, $enabled = true, $run_time = null, $interval = 21600, $max_run_time = 172800)
    Severity: Minor
    Found in src/JobDefinition.php - About 35 mins to fix

      Avoid too many return statements within this method.
      Open

                      return true;
      Severity: Major
      Found in src/JobRunner.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return true;
        Severity: Major
        Found in src/JobRunner.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return false;
          Severity: Major
          Found in src/JobRunner.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return false;
            Severity: Major
            Found in src/JobRunner.php - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language