Sign upLogin

barsoom/sie

View on GitHub
Star

Showing 4 of 4 total issues

Method attributes_with_tokens has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

      def attributes_with_tokens
        line_entry_type.map { |attr_entry_type|
          token = tokens.shift
          next unless token
Severity: Minor
Found in lib/sie/parser/build_entry.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method add_balance_rows has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def add_balance_rows(label, year_index, account_numbers, date, &block)
Severity: Minor
Found in lib/sie/document.rb - About 35 mins to fix

    Method for has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.for(creditor, type)
      case type
      when :invoice
        creditor ? SUPPLIER_INVOICE : DEBTOR_INVOICE
      when :payment
    Severity: Minor
    Found in lib/sie/document/voucher_series.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_complete_entry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def build_complete_entry
        entry = build_empty_entry

        attributes_with_tokens.each do |attr, *attr_tokens|
          label = attr.is_a?(Hash) ? attr.fetch(:name) : attr
    Severity: Minor
    Found in lib/sie/parser/build_entry.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language