Sign upLogin

bcdice/BCDice

View on GitHub
Star

Showing 1,168 of 1,225 total issues

File Dracurouge.rb has 468 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BCDice
  module GameSystem
    class Dracurouge < Base
      # ゲームシステムの識別子
      ID = 'Dracurouge'
Severity: Minor
Found in lib/bcdice/game_system/Dracurouge.rb - About 7 hrs to fix

    Method eval_game_system_specific_command has a Cognitive Complexity of 46 (exceeds 5 allowed). Consider refactoring.
    Open

          def eval_game_system_specific_command(string)
        if /^\d+D\d+/i.match?(string)
          return roll_action(string)
        end
    Severity: Minor
    Found in lib/bcdice/game_system/TunnelsAndTrolls.rb - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class HeroScale has 50 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class HeroScale < Base
      # ゲームシステムの識別子
      ID = 'HeroScale'

      # ゲームシステム名
    Severity: Minor
    Found in lib/bcdice/game_system/HeroScale.rb - About 7 hrs to fix

      File DarkDaysDrive.rb has 442 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      module BCDice
  module GameSystem
    class DarkDaysDrive < Base
      # ゲームシステムの識別子
      ID = 'DarkDaysDrive'
      Severity: Minor
      Found in lib/bcdice/game_system/DarkDaysDrive.rb - About 6 hrs to fix

        Class Elysion has 47 methods (exceeds 20 allowed). Consider refactoring.
        Open

            class Elysion < Base
      # ゲームシステムの識別子
      ID = 'Elysion'

      # ゲームシステム名
        Severity: Minor
        Found in lib/bcdice/game_system/Elysion.rb - About 6 hrs to fix

          File ShinkuuGakuen.rb has 431 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          module BCDice
  module GameSystem
    class ShinkuuGakuen < Base
      # ゲームシステムの識別子
      ID = 'ShinkuuGakuen'
          Severity: Minor
          Found in lib/bcdice/game_system/ShinkuuGakuen.rb - About 6 hrs to fix

            Method eval_game_system_specific_command has 156 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def eval_game_system_specific_command(command)
        output = ""
        type = ""
        total_n = ""
            Severity: Major
            Found in lib/bcdice/game_system/MeikyuKingdomBasic.rb - About 6 hrs to fix

              File GardenOrder.rb has 420 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              module BCDice
  module GameSystem
    class GardenOrder < Base
      # ゲームシステムのの識別子
      ID = 'GardenOrder'
              Severity: Minor
              Found in lib/bcdice/game_system/GardenOrder.rb - About 6 hrs to fix

                File YankeeYogSothoth.rb has 412 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require "bcdice/dice_table/table"
require "bcdice/dice_table/d66_table"

module BCDice
  module GameSystem
                Severity: Minor
                Found in lib/bcdice/game_system/YankeeYogSothoth.rb - About 5 hrs to fix

                  File MeikyuKingdom.rb has 398 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  module BCDice
  module GameSystem
    class MeikyuKingdom < Base
      # ゲームシステムの識別子
      ID = 'MeikyuKingdom'
                  Severity: Minor
                  Found in lib/bcdice/game_system/MeikyuKingdom.rb - About 5 hrs to fix

                    File LogHorizon.rb has 396 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    require "bcdice/base"

module BCDice
  module GameSystem
    class LogHorizon < Base
                    Severity: Minor
                    Found in lib/bcdice/game_system/LogHorizon.rb - About 5 hrs to fix

                      Method translate_tables has 135 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              def translate_tables(locale)
          costume_challenge_girls = CostumeTable.from_i18n("BeginningIdol.tables.DT", locale)
          costume_road_to_prince = CostumeTable.from_i18n("BeginningIdol.tables.RC", locale)
          costume_fortune_stars = CostumeTable.from_i18n("BeginningIdol.tables.FC", locale)
                      Severity: Major
                      Found in lib/bcdice/game_system/beginning_idol/table.rb - About 5 hrs to fix

                        File TorgEternity.rb has 391 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        module BCDice
  module GameSystem
    class TorgEternity < Base
      # ゲームシステムの識別子
      ID = 'TorgEternity'
                        Severity: Minor
                        Found in lib/bcdice/game_system/TorgEternity.rb - About 5 hrs to fix

                          Method eval_game_system_specific_command has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
                          Open

                                def eval_game_system_specific_command(string)
        unless parse_ars(string) || parse_1r10(string)
          return nil
        end
                          Severity: Minor
                          Found in lib/bcdice/game_system/ArsMagica.rb - About 5 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          File MeikyuDays.rb has 385 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          module BCDice
  module GameSystem
    class MeikyuDays < Base
      # ゲームシステムの識別子
      ID = 'MeikyuDays'
                          Severity: Minor
                          Found in lib/bcdice/game_system/MeikyuDays.rb - About 5 hrs to fix

                            Method eval_game_system_specific_command has 131 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                  def eval_game_system_specific_command(command)
        case command.upcase
        when /^(\d+)A(\d*)([CF]?)(\d*)([CF]?)(\d*)$/
          counts = Regexp.last_match(1).to_i
          judgment = Regexp.last_match(2).to_i
                            Severity: Major
                            Found in lib/bcdice/game_system/BladeOfArcana.rb - About 5 hrs to fix

                              File name_table.rb has 382 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              module BCDice
  module GameSystem
    class MeikyuKingdomBasic
      # エキゾチック名前表(D66)
      # override
                              Severity: Minor
                              Found in lib/bcdice/game_system/meikyu_kingdom_basic/name_table.rb - About 5 hrs to fix

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                          DiceTable::RangeTable.new(
            I18n.translate("DoubleCross.ET.negative.name", locale: locale),
            "1D100",
            [
              # [0, '侮蔑(ぶべつ)'],
                                Severity: Major
                                Found in lib/bcdice/game_system/DoubleCross.rb and 1 other location - About 5 hrs to fix
                                lib/bcdice/game_system/DoubleCross.rb on lines 295..322

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 171.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 2 locations. Consider refactoring.
                                Open

                                          DiceTable::RangeTable.new(
            I18n.translate("DoubleCross.ET.positive.name", locale: locale),
            "1D100",
            [
              # [0, '傾倒(けいとう)'],
                                Severity: Major
                                Found in lib/bcdice/game_system/DoubleCross.rb and 1 other location - About 5 hrs to fix
                                lib/bcdice/game_system/DoubleCross.rb on lines 329..356

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 171.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                File BlindMythos.rb has 379 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                module BCDice
  module GameSystem
    class BlindMythos < Base
      # ゲームシステムの識別子
      ID = 'BlindMythos'
                                Severity: Minor
                                Found in lib/bcdice/game_system/BlindMythos.rb - About 5 hrs to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language