Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/Cthulhu7th.rb

Summary

Maintainability
D
2 days
Test Coverage
A
99%

File Cthulhu7th.rb has 481 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "bcdice/game_system/cthulhu7th/rollable"
require "bcdice/game_system/cthulhu7th/full_auto"

module BCDice
  module GameSystem
Severity: Minor
Found in lib/bcdice/game_system/Cthulhu7th.rb - About 7 hrs to fix

    Method skill_roll has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

          def skill_roll(command)
        m = /^CC([-+]?\d+)?(?:<=(\d+)([RHEC])?)?$/.match(command)
        unless m
          return nil
        end
    Severity: Minor
    Found in lib/bcdice/game_system/Cthulhu7th.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method skill_roll has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def skill_roll(command)
        m = /^CC([-+]?\d+)?(?:<=(\d+)([RHEC])?)?$/.match(command)
        unless m
          return nil
        end
    Severity: Minor
    Found in lib/bcdice/game_system/Cthulhu7th.rb - About 1 hr to fix

      Method from_values has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

              def self.from_values(total, difficulty, fumbleable = false)
          fumble = difficulty < 50 || fumbleable ? 96 : 100

          if total == 1
            ResultLevel.new(:critical)
      Severity: Minor
      Found in lib/bcdice/game_system/Cthulhu7th.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method combine_roll has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def combine_roll(command)
        m = /^CBR\((\d+),(\d+)\)$/.match(command)
        return nil unless m

        difficulty_1 = m[1].to_i
      Severity: Minor
      Found in lib/bcdice/game_system/Cthulhu7th.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method with_difficulty_level has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def self.with_difficulty_level(total, difficulty)
          fumble = difficulty < 50 ? 96 : 100

          if total == 1
            ResultLevel.new(:critical)
      Severity: Minor
      Found in lib/bcdice/game_system/Cthulhu7th.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            MANIAS_TABLE = [
        '洗浄マニア：自分の体を洗わずにはいられない。',
        '無為マニア：病的な優柔不断。',
        '暗闇マニア：暗黒に関する過度の嗜好。',
        '高所マニア：高い場所に登らずにはいられない。',
      Severity: Major
      Found in lib/bcdice/game_system/Cthulhu7th.rb and 1 other location - About 2 hrs to fix
      lib/bcdice/game_system/Cthulhu7th.rb on lines 344..445

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            PHOBIAS_TABLE = [
        '入浴恐怖症：体、手、顔を洗うのが怖い。',
        '高所恐怖症：高いところが怖い。',
        '飛行恐怖症：飛ぶのが怖い。',
        '広場恐怖症：広場、公共の(混雑した)場所が怖い。',
      Severity: Major
      Found in lib/bcdice/game_system/Cthulhu7th.rb and 1 other location - About 2 hrs to fix
      lib/bcdice/game_system/Cthulhu7th.rb on lines 448..549

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            def roll_bmr_table()
        total_n = @randomizer.roll_once(10)
        text = MADNESS_REAL_TIME_TABLE[total_n - 1]

        time_n = @randomizer.roll_once(10)
      Severity: Minor
      Found in lib/bcdice/game_system/Cthulhu7th.rb and 3 other locations - About 20 mins to fix
      lib/bcdice/game_system/Cthulhu7th.rb on lines 297..303
      lib/bcdice/game_system/PulpCthulhu.rb on lines 90..96
      lib/bcdice/game_system/PulpCthulhu.rb on lines 113..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

            def roll_bms_table()
        total_n = @randomizer.roll_once(10)
        text = MADNESS_SUMMARY_TABLE[total_n - 1]

        time_n = @randomizer.roll_once(10)
      Severity: Minor
      Found in lib/bcdice/game_system/Cthulhu7th.rb and 3 other locations - About 20 mins to fix
      lib/bcdice/game_system/Cthulhu7th.rb on lines 274..280
      lib/bcdice/game_system/PulpCthulhu.rb on lines 90..96
      lib/bcdice/game_system/PulpCthulhu.rb on lines 113..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status