Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/GundogRevised.rb

Summary

Maintainability
D
2 days
Test Coverage
A
94%

Method getDamageTypeAndTable has 98 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def getDamageTypeAndTable(head)
        case head
        when "S"
          type = '射撃'
          # 射撃ダメージペナルティー表
Severity: Major
Found in lib/bcdice/game_system/GundogRevised.rb - About 3 hrs to fix

    Method getFumbleTypeAndTable has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def getFumbleTypeAndTable(head)
        case head
        when "S"
          type = '射撃'
          # 射撃ファンブル表
    Severity: Major
    Found in lib/bcdice/game_system/GundogRevised.rb - About 3 hrs to fix

      File GundogRevised.rb has 251 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'bcdice/game_system/Gundog'

module BCDice
  module GameSystem
    class GundogRevised < Base
      Severity: Minor
      Found in lib/bcdice/game_system/GundogRevised.rb - About 2 hrs to fix

        Method result_1d100 has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

              def result_1d100(total, _dice_total, cmp_op, target)
        return nil unless cmp_op == :<=

        if total >= 100
          Result.fumble("ファンブル")
        Severity: Minor
        Found in lib/bcdice/game_system/GundogRevised.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method eval_game_system_specific_command has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

              def eval_game_system_specific_command(command)
        string = command.upcase

        table = []
        ttype = ""
        Severity: Minor
        Found in lib/bcdice/game_system/GundogRevised.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def getDamageTypeAndTable(head)
        case head
        when "S"
          type = '射撃'
          # 射撃ダメージペナルティー表
        Severity: Major
        Found in lib/bcdice/game_system/GundogRevised.rb and 1 other location - About 3 hrs to fix
        lib/bcdice/game_system/GundogZero.rb on lines 69..175

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 122.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def getFumbleTypeAndTable(head)
        case head
        when "S"
          type = '射撃'
          # 射撃ファンブル表
        Severity: Major
        Found in lib/bcdice/game_system/GundogRevised.rb and 1 other location - About 2 hrs to fix
        lib/bcdice/game_system/GundogZero.rb on lines 178..257

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              def result_1d100(total, _dice_total, cmp_op, target)
        return nil unless cmp_op == :<=

        if total >= 100
          Result.fumble("ファンブル")
        Severity: Major
        Found in lib/bcdice/game_system/GundogRevised.rb and 1 other location - About 1 hr to fix
        lib/bcdice/game_system/Gundog.rb on lines 27..49

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                if /(\w)DPT([+\-\d]*)/i =~ string
          ttype = 'ダメージペナルティー'
          head = Regexp.last_match(1)
          mod = ArithmeticEvaluator.eval(Regexp.last_match(2)) if Regexp.last_match(2)
        Severity: Minor
        Found in lib/bcdice/game_system/GundogRevised.rb and 3 other locations - About 20 mins to fix
        lib/bcdice/game_system/GundogRevised.rb on lines 81..87
        lib/bcdice/game_system/GundogZero.rb on lines 40..46
        lib/bcdice/game_system/GundogZero.rb on lines 49..55

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                if /(\w)FT([+\-\d]*)/i =~ string
          ttype = 'ファンブル'
          head = Regexp.last_match(1)
          mod = ArithmeticEvaluator.eval(Regexp.last_match(2)) if Regexp.last_match(2)
        Severity: Minor
        Found in lib/bcdice/game_system/GundogRevised.rb and 3 other locations - About 20 mins to fix
        lib/bcdice/game_system/GundogRevised.rb on lines 72..78
        lib/bcdice/game_system/GundogZero.rb on lines 40..46
        lib/bcdice/game_system/GundogZero.rb on lines 49..55

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status