Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/KanColle.rb

Summary

Maintainability
D
2 days
Test Coverage
B
88%

File KanColle.rb has 754 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'bcdice/dice_table/table'

module BCDice
  module GameSystem
    class KanColle < Base
Severity: Major
Found in lib/bcdice/game_system/KanColle.rb - About 1 day to fix

    Method get_develop_matome_table has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def get_develop_matome_table
        output1 = ''
        output2 = ''
        total_n2 = ""
    Severity: Minor
    Found in lib/bcdice/game_system/KanColle.rb - About 1 hr to fix

      Method eval_game_system_specific_command has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def eval_game_system_specific_command(command)
        output = '1'
        type = ""
        total_n = ""
      Severity: Minor
      Found in lib/bcdice/game_system/KanColle.rb - About 1 hr to fix

        Method result_2d6 has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def result_2d6(_total, dice_total, _dice_list, cmp_op, _target)
        Severity: Minor
        Found in lib/bcdice/game_system/KanColle.rb - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  "WPFA" => DiceTable::Table.new(
          "艦載機開発表(燃料3/弾薬6/鋼材3/ボーキ6)",
          "4D6",
          [
            "開発失敗！(資材だけ失う)",
          Severity: Minor
          Found in lib/bcdice/game_system/KanColle.rb and 1 other location - About 20 mins to fix
          lib/bcdice/game_system/KanColle.rb on lines 615..640

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  "WPCN" => DiceTable::Table.new(
          "砲開発表(燃料3/弾薬6/鋼材6/ボーキ3)",
          "4D6",
          [
            "開発失敗！(資材だけ失う)",
          Severity: Minor
          Found in lib/bcdice/game_system/KanColle.rb and 1 other location - About 20 mins to fix
          lib/bcdice/game_system/KanColle.rb on lines 642..667

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status