Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/MeikyuKingdom.rb

Summary

Maintainability
D
2 days
Test Coverage
A
98%

Method eval_game_system_specific_command has 234 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def eval_game_system_specific_command(command)
        output = ""
        type = ""
        total_n = ""
Severity: Major
Found in lib/bcdice/game_system/MeikyuKingdom.rb - About 1 day to fix

    File MeikyuKingdom.rb has 398 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module BCDice
  module GameSystem
    class MeikyuKingdom < Base
      # ゲームシステムの識別子
      ID = 'MeikyuKingdom'
    Severity: Minor
    Found in lib/bcdice/game_system/MeikyuKingdom.rb - About 5 hrs to fix

      Method mayokin_check has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

            def mayokin_check(string)
        debug("mayokin_check string", string)

        string = replace_text(string)
      Severity: Minor
      Found in lib/bcdice/game_system/MeikyuKingdom.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method mayokin_check has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def mayokin_check(string)
        debug("mayokin_check string", string)

        string = replace_text(string)
      Severity: Minor
      Found in lib/bcdice/game_system/MeikyuKingdom.rb - About 1 hr to fix

        Method eval_game_system_specific_command has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def eval_game_system_specific_command(command)
        output = ""
        type = ""
        total_n = ""
        Severity: Minor
        Found in lib/bcdice/game_system/MeikyuKingdom.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method result_nd6 has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def result_nd6(total, dice_total, dice_list, cmp_op, target)
        Severity: Minor
        Found in lib/bcdice/game_system/MeikyuKingdom.rb - About 35 mins to fix

          Method result_nd6_only has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                def result_nd6_only(total, dice_total, cmp_op, target)
        return nil unless cmp_op == :>=

        if dice_total <= 2
          Result.fumble("絶対失敗")
          Severity: Minor
          Found in lib/bcdice/game_system/MeikyuKingdom.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  when /^KNT(\d+)/i
          type = '王国名'
          count = getCount(Regexp.last_match(1))
          total_n = @randomizer.roll_d66(D66SortType::ASC)
          Severity: Minor
          Found in lib/bcdice/game_system/MeikyuKingdom.rb and 1 other location - About 35 mins to fix
          lib/bcdice/game_system/MeikyuKingdomBasic.rb on lines 179..190

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 35.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status