bcit-ci/CodeIgniter

View on GitHub

Showing 872 of 872 total issues

File Form_validation.php has 752 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * CodeIgniter
 *
 * An open source application development framework for PHP
Severity: Major
Found in system/libraries/Form_validation.php - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function __construct($params)
        {
            parent::__construct($params);
    
            if (empty($this->dsn))
    Severity: Major
    Found in system/database/drivers/pdo/subdrivers/pdo_ibm_driver.php and 1 other location - About 1 day to fix
    system/database/drivers/pdo/subdrivers/pdo_odbc_driver.php on lines 104..159

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 359.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function __construct($params)
        {
            parent::__construct($params);
    
            if (empty($this->dsn))
    Severity: Major
    Found in system/database/drivers/pdo/subdrivers/pdo_odbc_driver.php and 1 other location - About 1 day to fix
    system/database/drivers/pdo/subdrivers/pdo_ibm_driver.php on lines 72..126

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 359.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File Loader.php has 717 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * CodeIgniter
     *
     * An open source application development framework for PHP
    Severity: Major
    Found in system/core/Loader.php - About 1 day to fix

      CI_DB_query_builder has 84 functions (exceeds 20 allowed). Consider refactoring.
      Open

      abstract class CI_DB_query_builder extends CI_DB_driver {
      
          /**
           * Return DELETE SQL flag
           *
      Severity: Major
      Found in system/database/DB_query_builder.php - About 1 day to fix

        Function _execute has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function _execute($row, $rules, $postdata = NULL, $cycles = 0)
            {
                $allow_arrays = in_array('is_array', $rules, TRUE);
        
                // If the $_POST data is an array we will run a recursive call
        Severity: Minor
        Found in system/libraries/Form_validation.php - About 1 day to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File Upload.php has 621 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        /**
         * CodeIgniter
         *
         * An open source application development framework for PHP
        Severity: Major
        Found in system/libraries/Upload.php - About 1 day to fix

          Function ip_address has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
          Open

              public function ip_address()
              {
                  if ($this->ip_address !== FALSE)
                  {
                      return $this->ip_address;
          Severity: Minor
          Found in system/core/Input.php - About 1 day to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              protected function _update_batch($table, $values, $index)
              {
                  $ids = array();
                  foreach ($values as $key => $val)
                  {
          Severity: Major
          Found in system/database/drivers/pdo/subdrivers/pdo_pgsql_driver.php and 1 other location - About 1 day to fix
          system/database/drivers/postgre/postgre_driver.php on lines 532..559

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 283.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              protected function _update_batch($table, $values, $index)
              {
                  $ids = array();
                  foreach ($values as $key => $val)
                  {
          Severity: Major
          Found in system/database/drivers/postgre/postgre_driver.php and 1 other location - About 1 day to fix
          system/database/drivers/pdo/subdrivers/pdo_pgsql_driver.php on lines 324..351

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 283.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          File form_helper.php has 563 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          /**
           * CodeIgniter
           *
           * An open source application development framework for PHP
          Severity: Major
          Found in system/helpers/form_helper.php - About 1 day to fix

            File DB_forge.php has 550 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            /**
             * CodeIgniter
             *
             * An open source application development framework for PHP
            Severity: Major
            Found in system/database/DB_forge.php - About 1 day to fix

              Method create_captcha has 229 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function create_captcha($data = '', $img_path = '', $img_url = '', $font_path = '')
                  {
                      $defaults = array(
                          'word'        => '',
                          'img_path'    => '',
              Severity: Major
              Found in system/helpers/captcha_helper.php - About 1 day to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function field_data($table)
                    {
                        if (($query = $this->query('PRAGMA TABLE_INFO('.$this->protect_identifiers($table, TRUE, NULL, FALSE).')')) === FALSE)
                        {
                            return FALSE;
                Severity: Major
                Found in system/database/drivers/pdo/subdrivers/pdo_sqlite_driver.php and 1 other location - About 1 day to fix
                system/database/drivers/sqlite3/sqlite3_driver.php on lines 255..280

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 265.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public function field_data($table)
                    {
                        if (($query = $this->query('PRAGMA TABLE_INFO('.$this->protect_identifiers($table, TRUE, NULL, FALSE).')')) === FALSE)
                        {
                            return FALSE;
                Severity: Major
                Found in system/database/drivers/sqlite3/sqlite3_driver.php and 1 other location - About 1 day to fix
                system/database/drivers/pdo/subdrivers/pdo_sqlite_driver.php on lines 153..178

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 265.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                CI_Email has 61 functions (exceeds 20 allowed). Consider refactoring.
                Open

                class CI_Email {
                
                    /**
                     * Used as the User-Agent and X-Mailer headers' value.
                     *
                Severity: Major
                Found in system/libraries/Email.php - About 1 day to fix

                  File Encryption.php has 529 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  <?php
                  /**
                   * CodeIgniter
                   *
                   * An open source application development framework for PHP
                  Severity: Major
                  Found in system/libraries/Encryption.php - About 1 day to fix

                    File Session.php has 524 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    <?php
                    /**
                     * CodeIgniter
                     *
                     * An open source application development framework for PHP
                    Severity: Major
                    Found in system/libraries/Session/Session.php - About 1 day to fix

                      Function create_links has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function create_links()
                          {
                              // If our item count or per-page total is zero there is no need to continue.
                              // Note: DO NOT change the operator to === here!
                              if ($this->total_rows == 0 OR $this->per_page == 0)
                      Severity: Minor
                      Found in system/libraries/Pagination.php - About 1 day to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      CI_DB_driver has 56 functions (exceeds 20 allowed). Consider refactoring.
                      Open

                      abstract class CI_DB_driver {
                      
                          /**
                           * Data Source Name / Connect string
                           *
                      Severity: Major
                      Found in system/database/DB_driver.php - About 1 day to fix
                        Severity
                        Category
                        Status
                        Source
                        Language