bcit-ci/CodeIgniter

View on GitHub
system/core/Hooks.php

Summary

Maintainability
C
1 day
Test Coverage

Function _run_hook has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    protected function _run_hook($data)
    {
        // Closures/lambda functions and array($object, 'method') callables
        if (is_callable($data))
        {
Severity: Minor
Found in system/core/Hooks.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _run_hook has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _run_hook($data)
    {
        // Closures/lambda functions and array($object, 'method') callables
        if (is_callable($data))
        {
Severity: Major
Found in system/core/Hooks.php - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

                        return $this->_in_progress = FALSE;
    Severity: Major
    Found in system/core/Hooks.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return FALSE;
      Severity: Major
      Found in system/core/Hooks.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->_in_progress = FALSE;
        Severity: Major
        Found in system/core/Hooks.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                              return $this->_in_progress = FALSE;
          Severity: Major
          Found in system/core/Hooks.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return FALSE;
            Severity: Major
            Found in system/core/Hooks.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return TRUE;
              Severity: Major
              Found in system/core/Hooks.php - About 30 mins to fix

                Function call_hook has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function call_hook($which = '')
                    {
                        if ( ! $this->enabled OR ! isset($this->hooks[$which]))
                        {
                            return FALSE;
                Severity: Minor
                Found in system/core/Hooks.php - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                There are no issues that match your filters.

                Category
                Status