bcit-ci/CodeIgniter

View on GitHub
system/core/Security.php

Summary

Maintainability
F
3 days
Test Coverage

File Security.php has 488 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * CodeIgniter
 *
 * An open source application development framework for PHP
Severity: Minor
Found in system/core/Security.php - About 7 hrs to fix

    Method xss_clean has 94 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function xss_clean($str, $is_image = FALSE)
        {
            // Is the string an array?
            if (is_array($str))
            {
    Severity: Major
    Found in system/core/Security.php - About 3 hrs to fix

      CI_Security has 22 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class CI_Security {
      
          /**
           * List of sanitize filename strings
           *
      Severity: Minor
      Found in system/core/Security.php - About 2 hrs to fix

        Method _sanitize_naughty_html has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function _sanitize_naughty_html($matches)
            {
                static $naughty_tags    = array(
                    'alert', 'area', 'prompt', 'confirm', 'applet', 'audio', 'basefont', 'base', 'behavior', 'bgsound',
                    'blink', 'body', 'embed', 'expression', 'form', 'frameset', 'frame', 'head', 'html', 'ilayer',
        Severity: Major
        Found in system/core/Security.php - About 2 hrs to fix

          Method get_random_bytes has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function get_random_bytes($length)
              {
                  if (empty($length) OR ! ctype_digit((string) $length))
                  {
                      return FALSE;
          Severity: Minor
          Found in system/core/Security.php - About 1 hr to fix

            Function xss_clean has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public function xss_clean($str, $is_image = FALSE)
                {
                    // Is the string an array?
                    if (is_array($str))
                    {
            Severity: Minor
            Found in system/core/Security.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method entity_decode has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function entity_decode($str, $charset = NULL)
                {
                    if (strpos($str, '&') === FALSE)
                    {
                        return $str;
            Severity: Minor
            Found in system/core/Security.php - About 1 hr to fix

              Method csrf_verify has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function csrf_verify()
                  {
                      // If it's not a POST request we will set the CSRF cookie
                      if (strtoupper($_SERVER['REQUEST_METHOD']) !== 'POST')
                      {
              Severity: Minor
              Found in system/core/Security.php - About 1 hr to fix

                Function get_random_bytes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function get_random_bytes($length)
                    {
                        if (empty($length) OR ! ctype_digit((string) $length))
                        {
                            return FALSE;
                Severity: Minor
                Found in system/core/Security.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function csrf_verify has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function csrf_verify()
                    {
                        // If it's not a POST request we will set the CSRF cookie
                        if (strtoupper($_SERVER['REQUEST_METHOD']) !== 'POST')
                        {
                Severity: Minor
                Found in system/core/Security.php - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function _sanitize_naughty_html has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function _sanitize_naughty_html($matches)
                    {
                        static $naughty_tags    = array(
                            'alert', 'area', 'prompt', 'confirm', 'applet', 'audio', 'basefont', 'base', 'behavior', 'bgsound',
                            'blink', 'body', 'embed', 'expression', 'form', 'frameset', 'frame', 'head', 'html', 'ilayer',
                Severity: Minor
                Found in system/core/Security.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function __construct has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function __construct($charset)
                    {
                        $this->charset = $charset;
                
                        // Is CSRF protection enabled?
                Severity: Minor
                Found in system/core/Security.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function entity_decode has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                    public function entity_decode($str, $charset = NULL)
                    {
                        if (strpos($str, '&') === FALSE)
                        {
                            return $str;
                Severity: Minor
                Found in system/core/Security.php - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Avoid too many return statements within this method.
                Open

                                return $output;
                Severity: Major
                Found in system/core/Security.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return openssl_random_pseudo_bytes($length);
                  Severity: Major
                  Found in system/core/Security.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return FALSE;
                    Severity: Major
                    Found in system/core/Security.php - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                          public $filename_bad_chars =    array(
                              '../', '<!--', '-->', '<', '>',
                              "'", '"', '&', '$', '#',
                              '{', '}', '[', ']', '=',
                              ';', '?', '%20', '%22',
                      Severity: Major
                      Found in system/core/Security.php and 1 other location - About 1 hr to fix
                      system/helpers/inflector_helper.php on lines 241..273

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 95.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status