bcit-ci/CodeIgniter

View on GitHub
system/database/drivers/mysqli/mysqli_driver.php

Summary

Maintainability
D
2 days
Test Coverage

Method db_connect has 91 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function db_connect($persistent = FALSE)
    {
        // Do we have a socket path?
        if ($this->hostname[0] === '/')
        {
Severity: Major
Found in system/database/drivers/mysqli/mysqli_driver.php - About 3 hrs to fix

    Function db_connect has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        public function db_connect($persistent = FALSE)
        {
            // Do we have a socket path?
            if ($this->hostname[0] === '/')
            {
    Severity: Minor
    Found in system/database/drivers/mysqli/mysqli_driver.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 5 locations. Consider refactoring.
    Open

        public function field_data($table)
        {
            if (($query = $this->query('SHOW COLUMNS FROM '.$this->protect_identifiers($table, TRUE, NULL, FALSE))) === FALSE)
            {
                return FALSE;
    Severity: Major
    Found in system/database/drivers/mysqli/mysqli_driver.php and 4 other locations - About 1 day to fix
    system/database/drivers/cubrid/cubrid_driver.php on lines 332..356
    system/database/drivers/mysql/mysql_driver.php on lines 418..442
    system/database/drivers/pdo/subdrivers/pdo_cubrid_driver.php on lines 145..169
    system/database/drivers/pdo/subdrivers/pdo_mysql_driver.php on lines 315..339

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 212.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        protected function _list_tables($prefix_limit = FALSE)
        {
            $sql = 'SHOW TABLES FROM '.$this->_escape_char.$this->database.$this->_escape_char;
    
            if ($prefix_limit !== FALSE && $this->dbprefix !== '')
    Severity: Minor
    Found in system/database/drivers/mysqli/mysqli_driver.php and 1 other location - About 45 mins to fix
    system/database/drivers/mysql/mysql_driver.php on lines 383..393

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status