bcit-ci/CodeIgniter

View on GitHub
system/database/drivers/oci8/oci8_driver.php

Summary

Maintainability
C
1 day
Test Coverage

Function __construct has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct($params)
    {
        parent::__construct($params);

        $valid_dsns = array(
Severity: Minor
Found in system/database/drivers/oci8/oci8_driver.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File oci8_driver.php has 253 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * CodeIgniter
 *
 * An open source application development framework for PHP
Severity: Minor
Found in system/database/drivers/oci8/oci8_driver.php - About 2 hrs to fix

    Method __construct has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct($params)
        {
            parent::__construct($params);
    
            $valid_dsns = array(
    Severity: Minor
    Found in system/database/drivers/oci8/oci8_driver.php - About 1 hr to fix

      Method field_data has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function field_data($table)
          {
              if (strpos($table, '.') !== FALSE)
              {
                  sscanf($table, '%[^.].%s', $owner, $table);
      Severity: Minor
      Found in system/database/drivers/oci8/oci8_driver.php - About 1 hr to fix

        Function field_data has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function field_data($table)
            {
                if (strpos($table, '.') !== FALSE)
                {
                    sscanf($table, '%[^.].%s', $owner, $table);
        Severity: Minor
        Found in system/database/drivers/oci8/oci8_driver.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

                if (preg_match($valid_dsns['tns'], $this->hostname))
                {
                    $this->dsn = $this->hostname;
                    return;
                }
        Severity: Major
        Found in system/database/drivers/oci8/oci8_driver.php - About 40 mins to fix

          Avoid too many return statements within this method.
          Open

                          return;
          Severity: Major
          Found in system/database/drivers/oci8/oci8_driver.php - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                protected function _insert_batch($table, $keys, $values)
                {
                    $keys = implode(', ', $keys);
                    $sql = "INSERT ALL\n";
            
            
            Severity: Major
            Found in system/database/drivers/oci8/oci8_driver.php and 1 other location - About 1 hr to fix
            system/database/drivers/pdo/subdrivers/pdo_oci_driver.php on lines 269..280

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 112.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                protected function _list_columns($table = '')
                {
                    if (strpos($table, '.') !== FALSE)
                    {
                        sscanf($table, '%[^.].%s', $owner, $table);
            Severity: Major
            Found in system/database/drivers/oci8/oci8_driver.php and 2 other locations - About 1 hr to fix
            system/database/drivers/pdo/subdrivers/pdo_informix_driver.php on lines 165..181
            system/database/drivers/pdo/subdrivers/pdo_oci_driver.php on lines 187..201

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status