bcit-ci/CodeIgniter

View on GitHub
system/database/drivers/pdo/subdrivers/pdo_sqlsrv_driver.php

Summary

Maintainability
F
5 days
Test Coverage

Method __construct has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($params)
    {
        parent::__construct($params);

        if (empty($this->dsn))
Severity: Minor
Found in system/database/drivers/pdo/subdrivers/pdo_sqlsrv_driver.php - About 1 hr to fix

    Function __construct has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct($params)
        {
            parent::__construct($params);
    
            if (empty($this->dsn))
    Severity: Minor
    Found in system/database/drivers/pdo/subdrivers/pdo_sqlsrv_driver.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method _limit has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function _limit($sql)
        {
            // As of SQL Server 2012 (11.0.*) OFFSET is supported
            if (version_compare($this->version(), '11', '>='))
            {
    Severity: Minor
    Found in system/database/drivers/pdo/subdrivers/pdo_sqlsrv_driver.php - About 1 hr to fix

      Function _limit has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _limit($sql)
          {
              // As of SQL Server 2012 (11.0.*) OFFSET is supported
              if (version_compare($this->version(), '11', '>='))
              {
      Severity: Minor
      Found in system/database/drivers/pdo/subdrivers/pdo_sqlsrv_driver.php - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function _limit($sql)
          {
              // As of SQL Server 2012 (11.0.*) OFFSET is supported
              if (version_compare($this->version(), '11', '>='))
              {
      Severity: Major
      Found in system/database/drivers/pdo/subdrivers/pdo_sqlsrv_driver.php and 1 other location - About 2 days to fix
      system/database/drivers/sqlsrv/sqlsrv_driver.php on lines 459..506

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 447.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          public function field_data($table)
          {
              $sql = 'SELECT COLUMN_NAME, DATA_TYPE, CHARACTER_MAXIMUM_LENGTH, NUMERIC_PRECISION, COLUMN_DEFAULT
                  FROM INFORMATION_SCHEMA.Columns
                  WHERE UPPER(TABLE_NAME) = '.$this->escape(strtoupper($table));
      system/database/drivers/mssql/mssql_driver.php on lines 312..335
      system/database/drivers/pdo/subdrivers/pdo_dblib_driver.php on lines 200..223
      system/database/drivers/pdo/subdrivers/pdo_pgsql_driver.php on lines 269..292
      system/database/drivers/postgre/postgre_driver.php on lines 436..459
      system/database/drivers/sqlsrv/sqlsrv_driver.php on lines 330..353

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 204.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          protected function _list_tables($prefix_limit = FALSE)
          {
              $sql = 'SELECT '.$this->escape_identifiers('name')
                  .' FROM '.$this->escape_identifiers('sysobjects')
                  .' WHERE '.$this->escape_identifiers('type')." = 'U'";
      system/database/drivers/pdo/subdrivers/pdo_dblib_driver.php on lines 160..173
      system/database/drivers/sqlsrv/sqlsrv_driver.php on lines 290..303

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 148.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status