bcit-ci/CodeIgniter

View on GitHub
system/database/drivers/postgre/postgre_driver.php

Summary

Maintainability
F
4 days
Test Coverage

CI_DB_postgre_driver has 23 functions (exceeds 20 allowed). Consider refactoring.
Open

class CI_DB_postgre_driver extends CI_DB {

    /**
     * Database driver
     *
Severity: Minor
Found in system/database/drivers/postgre/postgre_driver.php - About 2 hrs to fix

    File postgre_driver.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * CodeIgniter
     *
     * An open source application development framework for PHP
    Severity: Minor
    Found in system/database/drivers/postgre/postgre_driver.php - About 2 hrs to fix

      Method __construct has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct($params)
          {
              parent::__construct($params);
      
              if ( ! empty($this->dsn))
      Severity: Minor
      Found in system/database/drivers/postgre/postgre_driver.php - About 1 hr to fix

        Method insert_id has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function insert_id()
            {
                $v = $this->version();
        
                $table    = (func_num_args() > 0) ? func_get_arg(0) : NULL;
        Severity: Minor
        Found in system/database/drivers/postgre/postgre_driver.php - About 1 hr to fix

          Function __construct has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __construct($params)
              {
                  parent::__construct($params);
          
                  if ( ! empty($this->dsn))
          Severity: Minor
          Found in system/database/drivers/postgre/postgre_driver.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function insert_id has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function insert_id()
              {
                  $v = $this->version();
          
                  $table    = (func_num_args() > 0) ? func_get_arg(0) : NULL;
          Severity: Minor
          Found in system/database/drivers/postgre/postgre_driver.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _update_batch has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function _update_batch($table, $values, $index)
              {
                  $ids = array();
                  foreach ($values as $key => $val)
                  {
          Severity: Minor
          Found in system/database/drivers/postgre/postgre_driver.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function db_connect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function db_connect($persistent = FALSE)
              {
                  $this->conn_id = ($persistent === TRUE)
                      ? pg_pconnect($this->dsn)
                      : pg_connect($this->dsn);
          Severity: Minor
          Found in system/database/drivers/postgre/postgre_driver.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function order_by has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function order_by($orderby, $direction = '', $escape = NULL)
              {
                  $direction = strtoupper(trim($direction));
                  if ($direction === 'RANDOM')
                  {
          Severity: Minor
          Found in system/database/drivers/postgre/postgre_driver.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              protected function _update_batch($table, $values, $index)
              {
                  $ids = array();
                  foreach ($values as $key => $val)
                  {
          Severity: Major
          Found in system/database/drivers/postgre/postgre_driver.php and 1 other location - About 1 day to fix
          system/database/drivers/pdo/subdrivers/pdo_pgsql_driver.php on lines 324..351

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 261.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

              public function field_data($table)
              {
                  $sql = 'SELECT "column_name", "data_type", "character_maximum_length", "numeric_precision", "column_default"
                      FROM "information_schema"."columns"
                      WHERE LOWER("table_name") = '.$this->escape(strtolower($table));
          Severity: Major
          Found in system/database/drivers/postgre/postgre_driver.php and 5 other locations - About 1 day to fix
          system/database/drivers/mssql/mssql_driver.php on lines 312..335
          system/database/drivers/pdo/subdrivers/pdo_dblib_driver.php on lines 200..223
          system/database/drivers/pdo/subdrivers/pdo_pgsql_driver.php on lines 269..292
          system/database/drivers/pdo/subdrivers/pdo_sqlsrv_driver.php on lines 224..247
          system/database/drivers/sqlsrv/sqlsrv_driver.php on lines 330..353

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 204.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function order_by($orderby, $direction = '', $escape = NULL)
              {
                  $direction = strtoupper(trim($direction));
                  if ($direction === 'RANDOM')
                  {
          Severity: Major
          Found in system/database/drivers/postgre/postgre_driver.php and 1 other location - About 5 hrs to fix
          system/database/drivers/pdo/subdrivers/pdo_pgsql_driver.php on lines 195..218

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 154.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              protected function _list_tables($prefix_limit = FALSE)
              {
                  $sql = 'SELECT "table_name" FROM "information_schema"."tables" WHERE "table_schema" = \''.$this->schema."'";
          
                  if ($prefix_limit !== FALSE && $this->dbprefix !== '')
          Severity: Major
          Found in system/database/drivers/postgre/postgre_driver.php and 2 other locations - About 1 hr to fix
          system/database/drivers/odbc/odbc_driver.php on lines 356..367
          system/database/drivers/pdo/subdrivers/pdo_odbc_driver.php on lines 202..213

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status