bcit-ci/CodeIgniter

View on GitHub
system/helpers/download_helper.php

Summary

Maintainability
C
1 day
Test Coverage

Function force_download has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    function force_download($filename = '', $data = '', $set_mime = FALSE)
    {
        if ($filename === '' OR $data === '')
        {
            return;
Severity: Minor
Found in system/helpers/download_helper.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method force_download has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function force_download($filename = '', $data = '', $set_mime = FALSE)
    {
        if ($filename === '' OR $data === '')
        {
            return;
Severity: Major
Found in system/helpers/download_helper.php - About 3 hrs to fix

    Avoid too many return statements within this method.
    Open

                return;
    Severity: Major
    Found in system/helpers/download_helper.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return;
      Severity: Major
      Found in system/helpers/download_helper.php - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status