bcit-ci/CodeIgniter

View on GitHub
system/libraries/Trackback.php

Summary

Maintainability
D
1 day
Test Coverage

Function send has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function send($tb_data)
    {
        if ( ! is_array($tb_data))
        {
            $this->set_error('The send() method must be passed an array');
Severity: Minor
Found in system/libraries/Trackback.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Trackback.php has 258 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * CodeIgniter
 *
 * An open source application development framework for PHP
Severity: Minor
Found in system/libraries/Trackback.php - About 2 hrs to fix

    Method send has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function send($tb_data)
        {
            if ( ! is_array($tb_data))
            {
                $this->set_error('The send() method must be passed an array');
    Severity: Minor
    Found in system/libraries/Trackback.php - About 1 hr to fix

      Function receive has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          public function receive()
          {
              foreach (array('url', 'title', 'blog_name', 'excerpt') as $val)
              {
                  if (empty($_POST[$val]))
      Severity: Minor
      Found in system/libraries/Trackback.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method process has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function process($url, $data)
          {
              $target = parse_url($url);
      
              // Open the socket
      Severity: Minor
      Found in system/libraries/Trackback.php - About 1 hr to fix

        Method convert_ascii has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function convert_ascii($str)
            {
                $count    = 1;
                $out    = '';
                $temp    = array();
        Severity: Minor
        Found in system/libraries/Trackback.php - About 1 hr to fix

          Function convert_ascii has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function convert_ascii($str)
              {
                  $count    = 1;
                  $out    = '';
                  $temp    = array();
          Severity: Minor
          Found in system/libraries/Trackback.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method receive has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function receive()
              {
                  foreach (array('url', 'title', 'blog_name', 'excerpt') as $val)
                  {
                      if (empty($_POST[$val]))
          Severity: Minor
          Found in system/libraries/Trackback.php - About 1 hr to fix

            Function get_id has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function get_id($url)
                {
                    $tb_id = '';
            
                    if (strpos($url, '?') !== FALSE)
            Severity: Minor
            Found in system/libraries/Trackback.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                            if (count($temp) === $count)
                            {
                                $number = ($count === 3)
                                    ? (($temp[0] % 16) * 4096) + (($temp[1] % 64) * 64) + ($temp[2] % 64)
                                    : (($temp[0] % 32) * 64) + ($temp[1] % 64);
            Severity: Major
            Found in system/libraries/Trackback.php and 1 other location - About 2 hrs to fix
            system/helpers/text_helper.php on lines 171..185

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status