bcit-ci/CodeIgniter

View on GitHub
system/libraries/Zip.php

Summary

Maintainability
D
1 day
Test Coverage

Function read_dir has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function read_dir($path, $preserve_filepath = TRUE, $root_path = NULL)
    {
        $path = rtrim($path, '/\\').DIRECTORY_SEPARATOR;
        if ( ! $fp = @opendir($path))
        {
Severity: Minor
Found in system/libraries/Zip.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _add_data has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _add_data($filepath, $data, $file_mtime, $file_mdate)
    {
        $filepath = str_replace('\\', '/', $filepath);

        $uncompressed_size = self::strlen($data);
Severity: Minor
Found in system/libraries/Zip.php - About 1 hr to fix

    Method _add_dir has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function _add_dir($dir, $file_mtime, $file_mdate)
        {
            $dir = str_replace('\\', '/', $dir);
    
            $this->zipdata .=
    Severity: Minor
    Found in system/libraries/Zip.php - About 1 hr to fix

      Method read_dir has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function read_dir($path, $preserve_filepath = TRUE, $root_path = NULL)
          {
              $path = rtrim($path, '/\\').DIRECTORY_SEPARATOR;
              if ( ! $fp = @opendir($path))
              {
      Severity: Minor
      Found in system/libraries/Zip.php - About 1 hr to fix

        Function read_file has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function read_file($path, $archive_filepath = FALSE)
            {
                if (file_exists($path) && FALSE !== ($data = file_get_contents($path)))
                {
                    if (is_string($archive_filepath))
        Severity: Minor
        Found in system/libraries/Zip.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    "\x50\x4b\x03\x04\x14\x00\x00\x00\x08\x00"
                    .pack('v', $file_mtime)
                    .pack('v', $file_mdate)
                    .pack('V', $crc32)
                    .pack('V', $compressed_size)
        Severity: Major
        Found in system/libraries/Zip.php and 1 other location - About 2 hrs to fix
        system/libraries/Zip.php on lines 285..293

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    "\x50\x4b\x01\x02\x00\x00\x0a\x00\x00\x00\x00\x00"
                    .pack('v', $file_mtime)
                    .pack('v', $file_mdate)
                    .pack('V',0) // crc32
                    .pack('V',0) // compressed filesize
        Severity: Major
        Found in system/libraries/Zip.php and 1 other location - About 2 hrs to fix
        system/libraries/Zip.php on lines 188..196

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    "\x50\x4b\x01\x02\x00\x00\x14\x00\x00\x00\x08\x00"
                    .pack('v', $file_mtime)
                    .pack('v', $file_mdate)
                    .pack('V', $crc32)
                    .pack('V', $compressed_size)
        Severity: Major
        Found in system/libraries/Zip.php and 1 other location - About 2 hrs to fix
        system/libraries/Zip.php on lines 273..281

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    "\x50\x4b\x03\x04\x0a\x00\x00\x00\x00\x00"
                    .pack('v', $file_mtime)
                    .pack('v', $file_mdate)
                    .pack('V', 0) // crc32
                    .pack('V', 0) // compressed filesize
        Severity: Major
        Found in system/libraries/Zip.php and 1 other location - About 2 hrs to fix
        system/libraries/Zip.php on lines 203..211

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status