beardcoder/sitemap_generator

Showing 27 of 27 total issues

Function mapToEntries has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring. Open

    protected function mapToEntries(array $typoScriptUrlEntry): void { if ($typoScriptUrlEntry['table'] && $typoScriptUrlEntry['active'] == 1) {$records = $this->getRecordsFromDatabase($typoScriptUrlEntry);
if ($this->getDatabaseConnection()->sql_num_rows($records) !== 0) {
Found in Classes/Domain/Repository/SitemapRepository.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"

File SitemapRepository.php has 320 lines of code (exceeds 250 allowed). Consider refactoring. Open

<?php
namespace Markussom\SitemapGenerator\Domain\Repository;

use TYPO3\CMS\Core\Cache\Frontend\FrontendInterface;
use Exception;
Found in Classes/Domain/Repository/SitemapRepository.php - About 3 hrs to fix

The class SitemapRepository has an overall complexity of 68 which is very high. The configured complexity threshold is 50. Open

class SitemapRepository
{
/**
* @var FieldValueService
*/

Since: PHPMD 0.2.5

The Weighted Method Count (WMC) of a class is a good indicator of how much time and effort is required to modify and maintain this class. The WMC metric is defined as the sum of complexities of all methods declared in a class. A large number of methods also means that this class has a greater potential impact on derived classes.

Example:

class Foo {
public function bar() {
if ($a ==$b)  {
if ($a1 ==$b1) {
fiddle();
} elseif ($a2 ==$b2) {
fiddle();
} else {
}
}
}
public function baz() {
if ($a ==$b) {
if ($a1 ==$b1) {
fiddle();
} elseif ($a2 ==$b2) {
fiddle();
} else {
}
}
}
// Several other complex methods
}

Function mapGoogleNewsEntries has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring. Open

    protected function mapGoogleNewsEntries(array $typoScriptUrlEntry): array {$records = $this->getRecordsFromDatabase($typoScriptUrlEntry);
$tableColumns =$GLOBALS['TCA'][$tablename]['columns']; Found in Classes/Service/OrderByService.php - About 2 hrs to fix Cognitive Complexity Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend. A method's cognitive complexity is based on a few simple rules: • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one • Code is considered more complex for each "break in the linear flow of the code" • Code is considered more complex when "flow breaking structures are nested" Further reading SitemapRepository has 22 functions (exceeds 20 allowed). Consider refactoring. Open class SitemapRepository { /** * @var FieldValueService */ Found in Classes/Domain/Repository/SitemapRepository.php - About 2 hrs to fix Avoid excessively long variable names like$googleNewsUrlEntriesConfig. Keep variable name length under 20. Open

        $googleNewsUrlEntriesConfig =$urlEntries = $GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_sitemapgenerator.']; Since: PHPMD 0.2 Detects when a field, formal or local variable is declared with a long name. Example: class Something { protected$reallyLongIntName = -3; // VIOLATION - Field
public static function main( array $argumentsList[] ) { // VIOLATION - Formal$otherReallyLongName = -5; // VIOLATION - Local
for ($interestingIntIndex = 0; // VIOLATION - For$interestingIntIndex < 10;
$interestingIntIndex++ ) { } } } Method mapToEntries has 38 lines of code (exceeds 25 allowed). Consider refactoring. Open  protected function mapToEntries(array$typoScriptUrlEntry): void
{
if ($typoScriptUrlEntry['table'] &&$typoScriptUrlEntry['active'] == 1) {
$records =$this->getRecordsFromDatabase($typoScriptUrlEntry); if ($this->getDatabaseConnection()->sql_num_rows($records) !== 0) { Found in Classes/Domain/Repository/SitemapRepository.php - About 1 hr to fix Method mapGoogleNewsEntries has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open  protected function mapGoogleNewsEntries(array$typoScriptUrlEntry): array
{
$records =$this->getRecordsFromDatabase($typoScriptUrlEntry);$urlEntries = [];
if ($this->getDatabaseConnection()->sql_num_rows($records) !== 0) {
Found in Classes/Domain/Repository/SitemapRepository.php - About 1 hr to fix

    private function getRecordsFromDatabase($typoScriptUrlEntry) { if (!isset($GLOBALS['TCA'][$typoScriptUrlEntry['table']]) || !is_array($GLOBALS['TCA'][$typoScriptUrlEntry['table']]['ctrl']) ) { Found in Classes/Domain/Repository/SitemapRepository.php - About 1 hr to fix Function getEntriesFromPages has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open  public function getEntriesFromPages($pages): void
{
foreach ($pages as$page) {
if ($this->hasPageAnAllowedDoktype($page)) {
$urlEntry = GeneralUtility::makeInstance(UrlEntry::class); Found in Classes/Domain/Repository/SitemapRepository.php - About 55 mins to fix Cognitive Complexity Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend. A method's cognitive complexity is based on a few simple rules: • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one • Code is considered more complex for each "break in the linear flow of the code" • Code is considered more complex when "flow breaking structures are nested" Further reading Avoid deeply nested control flow statements. Open  if (isset($typoScriptUrlEntry['changefreq'])) {
$urlEntry->setChangefreq($this->fieldValueService->getFieldValue('changefreq', $typoScriptUrlEntry,$row)
);
}
Found in Classes/Domain/Repository/SitemapRepository.php - About 45 mins to fix

Avoid deeply nested control flow statements. Open

                        if (isset($typoScriptUrlEntry['priority'])) {$urlEntry->setPriority(
number_format(
$this->fieldValueService->getFieldValue('priority',$typoScriptUrlEntry, $row) / 10, 1, Found in Classes/Domain/Repository/SitemapRepository.php - About 45 mins to fix Avoid deeply nested control flow statements. Open  if (isset($typoScriptUrlEntry['lastmod'])) {
$urlEntry->setLastmod( date( 'Y-m-d',$this->fieldValueService->getFieldValue('lastmod', $typoScriptUrlEntry,$row)
Found in Classes/Domain/Repository/SitemapRepository.php - About 45 mins to fix

The class SitemapRepository has a coupling between objects value of 20. Consider to reduce the number of dependencies under 13. Open

class SitemapRepository
{
/**
* @var FieldValueService
*/

Since: PHPMD 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example:

class Foo {
/**
* @var \foo\bar\X
*/
private $x = null; /** * @var \foo\bar\Y */ private$y = null;

/**
* @var \foo\bar\Z
*/
private $z = null; public function setFoo(\Foo$foo) {}
public function setBar(\Bar $bar) {} public function setBaz(\Baz$baz) {}

/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {} // ... } There must be one blank line after the last USE statement; 0 found; Open use TYPO3\CMS\Core\Utility\ExtensionManagementUtility; There must be one blank line after the last USE statement; 0 found; Open use Markussom\SitemapGenerator\Command\TaskCommandController; Found in ext_localconf.php by phpcodesniffer There must be one blank line after the last USE statement; 0 found; Open use TYPO3\CMS\Core\Utility\ExtensionManagementUtility; Function getLimitString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open  public static function getLimitString($limit)
{
if (isset($limit) && !empty($limit)) {
$limitParts = GeneralUtility::trimExplode(',',$limit);
if (count($limitParts) === 1) { Found in Classes/Service/LimitService.php - About 25 mins to fix Cognitive Complexity Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend. A method's cognitive complexity is based on a few simple rules: • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one • Code is considered more complex for each "break in the linear flow of the code" • Code is considered more complex when "flow breaking structures are nested" Further reading Function hidePagesIfNotTranslated has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open  private function hidePagesIfNotTranslated(array$pages): array
{
$language = GeneralUtility::_GET('L'); if ($this->isPageNotTranslated($language)) { foreach ($pages as $key =>$page) {
Found in Classes/Domain/Repository/SitemapRepository.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

• Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
• Code is considered more complex for each "break in the linear flow of the code"
• Code is considered more complex when "flow breaking structures are nested"