Showing 27 of 27 total issues
Avoid unused local variables such as '$urlEntries'. Open
$googleNewsUrlEntriesConfig = $urlEntries = $GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_sitemapgenerator.'];- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
The method getPages uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$pages = $this->getSubPagesRecursive($rootPageId);
$this->cacheInstance->set($cacheIdentifier, $pages, ['pagesForSitemap']);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
generateEntriesFromTypoScript accesses the super-global variable $GLOBALS. Open
public function generateEntriesFromTypoScript(): void
{
$urlEntries = $GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_sitemapgenerator.']['urlEntries.'];
foreach ($urlEntries as $urlEntry) {
if (!empty($urlEntry['active'])) {- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
findAllGoogleNewsEntries accesses the super-global variable $GLOBALS. Open
public function findAllGoogleNewsEntries()
{
$googleNewsUrlEntriesConfig = $urlEntries = $GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_sitemapgenerator.'];
if (!isset($googleNewsUrlEntriesConfig['googleNewsUrlEntry'])
|| !MathUtility::canBeInterpretedAsInteger($googleNewsUrlEntriesConfig['googleNewsUrlEntry'])- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
The method getOrderByString() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10. Open
public static function getOrderByString($orderBy, $tablename): string
{
if (isset($orderBy) && !empty($orderBy)) {
$cleanOrderByParts = [];
$tableColumns = $GLOBALS['TCA'][$tablename]['columns'];- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
getOrderByString accesses the super-global variable $GLOBALS. Open
public static function getOrderByString($orderBy, $tablename): string
{
if (isset($orderBy) && !empty($orderBy)) {
$cleanOrderByParts = [];
$tableColumns = $GLOBALS['TCA'][$tablename]['columns'];- Read upRead up
- Exclude checks
Superglobals
Since: 0.2
Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.
Example
class Foo {
public function bar() {
$name = $_POST['foo'];
}
}Source
Line exceeds 120 characters; contains 127 characters Open
return $record['sys_language_uid'] !== '-1' && (int)$language !== 0 && (int)$recordConfig['hideIfNotTranslated'] === 1;- Exclude checks