believer/telefonnummer

View on GitHub

Showing 5 of 5 total issues

File riktnummer.js has 266 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module.exports = [
  '011 Norrköping',
  '0120 Åtvidaberg',
  '0121 Söderköping',
  '0122 Finspång',
Severity: Minor
Found in lib/riktnummer.js - About 2 hrs to fix

    Function phoneNumberParser has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

    function phoneNumberParser(number, separator = '-') {
      if (!number) {
        return ''
      }
    
    
    Severity: Minor
    Found in lib/parser.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function phoneNumberParser has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function phoneNumberParser(number, separator = '-') {
      if (!number) {
        return ''
      }
    
    
    Severity: Minor
    Found in lib/parser.js - About 1 hr to fix

      Function numberingArea has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function numberingArea(number) {
        if (!number) {
          return ''
        }
      
      
      Severity: Minor
      Found in lib/numberingArea.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

        return findNumbersByLength(4, 6).test(normalized)
      Severity: Major
      Found in lib/validator.js - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language