bemusic/bemuse

View on GitHub
bemuse/src/app/analytics.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function gameFinish has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function gameFinish(song, chart, gameState, gameMode) {
  const player = gameState.game.players[0]
  const notechart = player.notechart
  const state = gameState.player(player)
  const stats = state.stats
Severity: Minor
Found in bemuse/src/app/analytics.js - About 1 hr to fix

    Function send has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function send(category, action, label, value, extra) {
      console.log('[Analytics]', category, action, label, value, extra)
      ga('send', 'event', category, action, label, value)
      try {
        if (window.ga) {
    Severity: Minor
    Found in bemuse/src/app/analytics.js - About 1 hr to fix

      Function send has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      export function send(category, action, label, value, extra) {
      Severity: Minor
      Found in bemuse/src/app/analytics.js - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export function gameEscape(song, chart, gameState) {
          const state = gameState.player(gameState.game.players[0])
          send('song', 'escape', getSongTitle(song))
          send('game', 'escape', getLabel(chart), state.stats.score)
        }
        Severity: Major
        Found in bemuse/src/app/analytics.js and 1 other location - About 2 hrs to fix
        bemuse/src/app/analytics.js on lines 116..120

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export function gameQuit(song, chart, gameState) {
          const state = gameState.player(gameState.game.players[0])
          send('song', 'quit', getSongTitle(song))
          send('game', 'quit', getLabel(chart), state.stats.score)
        }
        Severity: Major
        Found in bemuse/src/app/analytics.js and 1 other location - About 2 hrs to fix
        bemuse/src/app/analytics.js on lines 110..114

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 76.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status