Sign upLogin

bengl/mongosmash

View on GitHub
Star

Showing 3 of 3 total issues

Function queryGenerator has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function queryGenerator(list, smash){
  if (list.indexOf('insert') >= 0) return {insert: true};

  var query = {$set:{}, $unset:{}, _$incoriginal:{}};
  list.forEach(function(change){
Severity: Minor
Found in src/queryGenerator.js - About 1 hr to fix

    Function save has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      save (obj, cb) {
    let model;
    this.observers.get(obj).deliverChanges();
    let q = queryGenerator(this.changelists.get(obj) || [], this);
    if (q.insert || q.update) model = this.modelnames.get(obj);
    Severity: Minor
    Found in src/mongosmash.js - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

      return true;
    Severity: Major
    Found in src/queryGenerator.js - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language