berkes/spree_billing_sisow

View on GitHub

Showing 2 of 2 total issues

Method confirm_sisow has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def confirm_sisow
      return unless confirm_params_valid?
      return unless sisow_payment_method?(payment_method)

      if payment_method.is_a?(PaymentMethod::SisowBilling::Ideal)
Severity: Minor
Found in app/controllers/spree/checkout_controller_decorator.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_response has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def process_response(response)
      if @order.payments.where(:source_type => 'Spree::SisowTransaction').present?
        initialize_callback(response)

        if @callback.valid?
Severity: Minor
Found in app/models/spree/payment_method/sisow_billing.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language