beyond-blockchain/bbclib-go

View on GitHub

Showing 22 of 32 total issues

BBcTransaction has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

    BBcTransaction struct {
        digestCalculating     bool
        IdLengthConf          BBcIdConfig
        TransactionID         []byte
        TransactionBaseDigest []byte
Severity: Minor
Found in transaction.go - About 2 hrs to fix

    File transaction.go has 507 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    /*
    Copyright (c) 2018 Zettant Inc.
    
    Licensed under the Apache License, Version 2.0 (the "License");
    you may not use this file except in compliance with the License.
    Severity: Minor
    Found in transaction.go - About 2 hrs to fix

      Method BBcRelation.Pack has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
      Open

      func (p *BBcRelation) Pack() ([]byte, error) {
          if p.AssetGroupID == nil {
              return nil, errors.New("need asset_group_id in BBcRelation")
          }
          buf := new(bytes.Buffer)
      Severity: Minor
      Found in relation.go - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method BBcRelation.Unpack has 65 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (p *BBcRelation) Unpack(dat *[]byte) error {
          if p.IdLengthConf == nil {
              p.IdLengthConf = &BBcIdConfig{}
          }
      
      
      Severity: Minor
      Found in relation.go - About 1 hr to fix

        Method BBcRelation.Pack has 55 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (p *BBcRelation) Pack() ([]byte, error) {
            if p.AssetGroupID == nil {
                return nil, errors.New("need asset_group_id in BBcRelation")
            }
            buf := new(bytes.Buffer)
        Severity: Minor
        Found in relation.go - About 1 hr to fix

          Method BBcTransaction.packBase has 55 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (p *BBcTransaction) packBase(buf *bytes.Buffer) error {
              Put4byte(buf, p.Version)
              if p.Timestamp == 0 {
                  p.Timestamp = time.Now().UnixNano() / int64(time.Microsecond)
              }
          Severity: Minor
          Found in transaction.go - About 1 hr to fix

            Method BBcRelation.Unpack has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
            Open

            func (p *BBcRelation) Unpack(dat *[]byte) error {
                if p.IdLengthConf == nil {
                    p.IdLengthConf = &BBcIdConfig{}
                }
            
            
            Severity: Minor
            Found in relation.go - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method BBcRelation.Unpack has 10 return statements (exceeds 4 allowed).
            Open

            func (p *BBcRelation) Unpack(dat *[]byte) error {
                if p.IdLengthConf == nil {
                    p.IdLengthConf = &BBcIdConfig{}
                }
            
            
            Severity: Major
            Found in relation.go - About 1 hr to fix

              Method BBcRelation.Pack has 10 return statements (exceeds 4 allowed).
              Open

              func (p *BBcRelation) Pack() ([]byte, error) {
                  if p.AssetGroupID == nil {
                      return nil, errors.New("need asset_group_id in BBcRelation")
                  }
                  buf := new(bytes.Buffer)
              Severity: Major
              Found in relation.go - About 1 hr to fix

                Method BBcTransaction.packBase has 9 return statements (exceeds 4 allowed).
                Open

                func (p *BBcTransaction) packBase(buf *bytes.Buffer) error {
                    Put4byte(buf, p.Version)
                    if p.Timestamp == 0 {
                        p.Timestamp = time.Now().UnixNano() / int64(time.Microsecond)
                    }
                Severity: Major
                Found in transaction.go - About 55 mins to fix

                  Method BBcTransaction.Unpack has 8 return statements (exceeds 4 allowed).
                  Open

                  func (p *BBcTransaction) Unpack(dat *[]byte) error {
                      buf := bytes.NewBuffer(*dat)
                  
                      if err := p.unpackHeader(buf); err != nil {
                          return err
                  Severity: Major
                  Found in transaction.go - About 50 mins to fix

                    Method BBcAsset.Unpack has 8 return statements (exceeds 4 allowed).
                    Open

                    func (p *BBcAsset) Unpack(dat *[]byte) error {
                        if p.IdLengthConf == nil {
                            p.IdLengthConf = &BBcIdConfig{}
                        }
                    
                    
                    Severity: Major
                    Found in asset.go - About 50 mins to fix

                      Method BBcEvent.Unpack has 7 return statements (exceeds 4 allowed).
                      Open

                      func (p *BBcEvent) Unpack(dat *[]byte) error {
                          if p.IdLengthConf == nil {
                              p.IdLengthConf = &BBcIdConfig{}
                          }
                      
                      
                      Severity: Major
                      Found in event.go - About 45 mins to fix

                        Method BBcReference.Unpack has 6 return statements (exceeds 4 allowed).
                        Open

                        func (p *BBcReference) Unpack(dat *[]byte) error {
                            if p.IdLengthConf == nil {
                                p.IdLengthConf = &BBcIdConfig{}
                            }
                        
                        
                        Severity: Major
                        Found in reference.go - About 40 mins to fix

                          Method BBcTransaction.Pack has 6 return statements (exceeds 4 allowed).
                          Open

                          func (p *BBcTransaction) Pack() ([]byte, error) {
                              if !p.digestCalculating && p.TransactionID == nil {
                                  p.Digest()
                              }
                          
                          
                          Severity: Major
                          Found in transaction.go - About 40 mins to fix

                            Method BBcEvent.unpackApprovers has 6 return statements (exceeds 4 allowed).
                            Open

                            func (p *BBcEvent) unpackApprovers(buf *bytes.Buffer) error {
                                numMandatory, err := Get2byte(buf)
                                if err != nil {
                                    return err
                                }
                            Severity: Major
                            Found in event.go - About 40 mins to fix

                              Function Deserialize has 6 return statements (exceeds 4 allowed).
                              Open

                              func Deserialize(dat []byte) (*BBcTransaction, error) {
                                  buf := bytes.NewBuffer(dat)
                              
                                  formatType, err := Get2byte(buf)
                                  if err != nil {
                              Severity: Major
                              Found in bbclib.go - About 40 mins to fix

                                Method KeyPair.ConvertFromPem has 5 return statements (exceeds 4 allowed).
                                Open

                                func (k *KeyPair) ConvertFromPem(pemstr string, compressionMode int) error {
                                    block, _ := pem.Decode([]byte(pemstr))
                                    if block == nil {
                                        return errors.New("invalid PEM format")
                                    }
                                Severity: Major
                                Found in keypair.go - About 35 mins to fix

                                  Method BBcSignature.Unpack has 5 return statements (exceeds 4 allowed).
                                  Open

                                  func (p *BBcSignature) Unpack(dat *[]byte) error {
                                      var err error
                                      buf := bytes.NewBuffer(*dat)
                                  
                                      keyType, err := Get4byte(buf)
                                  Severity: Major
                                  Found in signature.go - About 35 mins to fix

                                    Method BBcEvent.Pack has 5 return statements (exceeds 4 allowed).
                                    Open

                                    func (p *BBcEvent) Pack() ([]byte, error) {
                                        if len(p.OptionApprovers) != int(p.OptionApproverNumDenominator) {
                                            return nil, errors.New("num of option approvers must be equal to OptionApproverNumDenominator")
                                        }
                                        if p.AssetGroupID == nil {
                                    Severity: Major
                                    Found in event.go - About 35 mins to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language