Sign upLogin

bgabriel998/SoftwareDevProject

View on GitHub
Star

Showing 4 of 5 total issues

Method drawLine has a Cognitive Complexity of 70 (exceeds 15 allowed). Consider refactoring.
Open

    private List<Pair<Integer, Integer>> drawLine(int x1, int y1, int x2, int y2) {

        int pixelX = x2 - x1;
        int pixelY = y2 - y1;
Severity: Minor
Found in app/src/main/java/ch/epfl/sdp/peakar/points/LineOfSight.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (Math.abs(pixelY) >= Math.abs(pixelX)) {
            ratio = pixelX != 0 ? Math.abs(pixelY / pixelX) : Math.abs(pixelY);
            error = pixelX != 0 ? Math.abs((double) ratio - Math.abs(((double) pixelY / (double) pixelX))) : 0;
            for (x = x1, y = y1; x1 < x2 ? x <= x2 : x >= x2; x = x1 < x2 ? x+1 : x-1) {
                for (int i = 0; i < ratio && (y1 < y2 ? y <= y2 : y >= y2); i++) {
Severity: Major
Found in app/src/main/java/ch/epfl/sdp/peakar/points/LineOfSight.java and 1 other location - About 4 hrs to fix
app/src/main/java/ch/epfl/sdp/peakar/points/LineOfSight.java on lines 179..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 280.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        } else {
            ratio = pixelY != 0 ? Math.abs(pixelX / pixelY) : Math.abs(pixelX);
            error = pixelY != 0 ? Math.abs((double) ratio - Math.abs(((double) pixelX / (double) pixelY))) : 0;
            for (x = x1, y = y1; y1 < y2 ? y <= y2 : y >= y2; y = y1 < y2 ? y+1 : y-1) {
                for (int i = 0; i < ratio && (x1 < x2 ? x <= x2 : x >= x2); i++) {
Severity: Major
Found in app/src/main/java/ch/epfl/sdp/peakar/points/LineOfSight.java and 1 other location - About 4 hrs to fix
app/src/main/java/ch/epfl/sdp/peakar/points/LineOfSight.java on lines 164..179

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 280.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method computeMaxElevation has 7 arguments (exceeds 5 allowed). Consider refactoring.
Open

    private int computeMaxElevation(double userLatitude, double userLongitude,
                                    double userAltitude,
                                    int rowIndex, int colIndex, boolean useRow,
                                    double slope) {
Severity: Major
Found in app/src/main/java/ch/epfl/sdp/peakar/points/LineOfSight.java - About 45 mins to fix
    Severity
    Category
    Status
    Source
    Language