bgabriel998/SoftwareDevProject

View on GitHub

Showing 2 of 5 total issues

Method drawLine has a Cognitive Complexity of 70 (exceeds 15 allowed). Consider refactoring.
Open

    private List<Pair<Integer, Integer>> drawLine(int x1, int y1, int x2, int y2) {

        int pixelX = x2 - x1;
        int pixelY = y2 - y1;

Severity: Minor
Found in app/src/main/java/ch/epfl/sdp/peakar/points/LineOfSight.java - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method computeMaxElevation has 7 arguments (exceeds 5 allowed). Consider refactoring.
Open

    private int computeMaxElevation(double userLatitude, double userLongitude,
                                    double userAltitude,
                                    int rowIndex, int colIndex, boolean useRow,
                                    double slope) {
Severity: Major
Found in app/src/main/java/ch/epfl/sdp/peakar/points/LineOfSight.java - About 45 mins to fix
    Severity
    Category
    Status
    Source
    Language