Sign upLogin

bhollis/maruku

View on GitHub
Star
lib/maruku/input/parse_doc.rb

Summary

Maintainability
C
1 day
Test Coverage

Method search_abbreviations has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def search_abbreviations
    abbreviations.each do |abbrev, title|
      reg = Regexp.new(Regexp.escape(abbrev))
      replace_each_string do |s|
        # bug if many abbreviations are present (agorf)
Severity: Minor
Found in lib/maruku/input/parse_doc.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method expand_attribute_list has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def expand_attribute_list(al, result)
    al.each do |k, v|
      case k
      when :class
        if result[:class]
Severity: Minor
Found in lib/maruku/input/parse_doc.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_doc has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def parse_doc(s)
    # Remove BOM if it is present
    s = s.sub(/^\xEF\xBB\xBF/u, '')
    meta2 = parse_email_headers(s)
    data = meta2.delete :data
Severity: Minor
Found in lib/maruku/input/parse_doc.rb - About 1 hr to fix

    Method expand_attribute_list has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def expand_attribute_list(al, result)
    al.each do |k, v|
      case k
      when :class
        if result[:class]
    Severity: Minor
    Found in lib/maruku/input/parse_doc.rb - About 1 hr to fix

      Method parse_doc has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        def parse_doc(s)
    # Remove BOM if it is present
    s = s.sub(/^\xEF\xBB\xBF/u, '')
    meta2 = parse_email_headers(s)
    data = meta2.delete :data
      Severity: Minor
      Found in lib/maruku/input/parse_doc.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status